From: subramanian.mohan@intel.com
To: nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev,
lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com,
bhelgaas@google.com
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com,
srikanth.thokala@intel.com
Subject: [PATCH] PCI: vmd: Use devm_kasprintf instead of simple kasprintf
Date: Tue, 31 May 2022 18:56:17 +0530 [thread overview]
Message-ID: <20220531132617.20517-1-subramanian.mohan@intel.com> (raw)
From: Subramanian Mohan <subramanian.mohan@intel.com>
Use devm_kasprintf instead of simple kasprintf to free the allocated memory
automatically when the device is freed.
Suggested-by: Srikanth Thokala <srikanth.thokala@intel.com>
Signed-off-by: Subramanian Mohan <subramanian.mohan@intel.com>
Acked-by: Nirmal Patel <nirmal.patel@linux.intel.com>
---
drivers/pci/controller/vmd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index eb05cceab964..7a72948e001f 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -897,7 +897,8 @@ static int vmd_probe(struct pci_dev *dev, const struct pci_device_id *id)
if (vmd->instance < 0)
return vmd->instance;
- vmd->name = kasprintf(GFP_KERNEL, "vmd%d", vmd->instance);
+ vmd->name = devm_kasprintf(&dev->dev, GFP_KERNEL, "vmd%d",
+ vmd->instance);
if (!vmd->name) {
err = -ENOMEM;
goto out_release_instance;
@@ -935,7 +936,6 @@ static int vmd_probe(struct pci_dev *dev, const struct pci_device_id *id)
out_release_instance:
ida_simple_remove(&vmd_instance_ida, vmd->instance);
- kfree(vmd->name);
return err;
}
@@ -958,7 +958,6 @@ static void vmd_remove(struct pci_dev *dev)
vmd_detach_resources(vmd);
vmd_remove_irq_domain(vmd);
ida_simple_remove(&vmd_instance_ida, vmd->instance);
- kfree(vmd->name);
}
#ifdef CONFIG_PM_SLEEP
--
2.17.1
next reply other threads:[~2022-05-31 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 13:26 subramanian.mohan [this message]
2022-05-31 18:39 ` [PATCH] PCI: vmd: Use devm_kasprintf instead of simple kasprintf Bjorn Helgaas
2022-06-01 11:14 ` Mohan, Subramanian
2022-06-10 6:57 ` Mohan, Subramanian
2022-06-10 14:47 ` Bjorn Helgaas
2022-06-13 6:33 ` Mohan, Subramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531132617.20517-1-subramanian.mohan@intel.com \
--to=subramanian.mohan@intel.com \
--cc=bhelgaas@google.com \
--cc=jonathan.derrick@linux.dev \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=nirmal.patel@linux.intel.com \
--cc=robh@kernel.org \
--cc=srikanth.thokala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).