From: Bjorn Helgaas <helgaas@kernel.org>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
linux-pci@vger.kernel.org, "Xuefeng Li" <lixuefeng@loongson.cn>,
"Huacai Chen" <chenhuacai@gmail.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH V13 1/6] PCI: loongson: Use generic 8/16/32-bit config ops on LS2K/LS7A
Date: Tue, 31 May 2022 21:08:06 -0500 [thread overview]
Message-ID: <20220601020806.GA793482@bhelgaas> (raw)
In-Reply-To: <20220430084846.3127041-2-chenhuacai@loongson.cn>
On Sat, Apr 30, 2022 at 04:48:41PM +0800, Huacai Chen wrote:
> LS2K/LS7A support 8/16/32-bits PCI config access operations via CFG1, so
> we can disable CFG0 for them and safely use pci_generic_config_read()/
> pci_generic_config_write() instead of pci_generic_config_read32()/pci_
> generic_config_write32().
>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
After removing cast below,
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> @@ -193,20 +220,20 @@ static int loongson_pci_probe(struct platform_device *pdev)
>
> priv = pci_host_bridge_priv(bridge);
> priv->pdev = pdev;
> - priv->flags = (unsigned long)of_device_get_match_data(dev);
> + priv->data = (struct loongson_pci_data *)of_device_get_match_data(dev);
No cast needed.
next prev parent reply other threads:[~2022-06-01 2:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 8:48 [PATCH V13 0/6] PCI: Loongson pci improvements and quirks Huacai Chen
2022-04-30 8:48 ` [PATCH V13 1/6] PCI: loongson: Use generic 8/16/32-bit config ops on LS2K/LS7A Huacai Chen
2022-06-01 2:08 ` Bjorn Helgaas [this message]
2022-06-02 4:18 ` Huacai Chen
2022-04-30 8:48 ` [PATCH V13 2/6] PCI: loongson: Add ACPI init support Huacai Chen
2022-05-31 23:04 ` Bjorn Helgaas
2022-06-02 7:09 ` Huacai Chen
2022-04-30 8:48 ` [PATCH V13 3/6] PCI: loongson: Don't access unexisting devices Huacai Chen
2022-05-31 23:14 ` Bjorn Helgaas
2022-06-02 4:28 ` Huacai Chen
2022-06-02 16:23 ` Bjorn Helgaas
2022-06-02 20:00 ` Jiaxun Yang
2022-04-30 8:48 ` [PATCH V13 4/6] PCI: loongson: Improve the MRRS quirk for LS7A Huacai Chen
2022-06-01 2:22 ` Bjorn Helgaas
2022-06-01 11:59 ` Jiaxun Yang
2022-06-02 4:17 ` Huacai Chen
2022-06-02 16:20 ` Bjorn Helgaas
2022-06-03 12:13 ` Krzysztof Hałasa
2022-06-03 22:57 ` Jiaxun Yang
2022-06-04 0:07 ` Bjorn Helgaas
2022-06-08 8:29 ` Huacai Chen
2022-04-30 8:48 ` [PATCH V13 5/6] PCI: Add quirk for LS7A to avoid reboot failure Huacai Chen
2022-05-31 23:35 ` Bjorn Helgaas
2022-06-02 12:48 ` Huacai Chen
2022-06-02 16:29 ` Bjorn Helgaas
2022-06-08 9:34 ` Huacai Chen
2022-06-08 19:31 ` Bjorn Helgaas
2022-06-16 8:39 ` Huacai Chen
2022-06-16 22:57 ` Bjorn Helgaas
2022-06-17 2:21 ` Huacai Chen
2022-06-17 11:37 ` Bjorn Helgaas
2022-06-17 12:14 ` Huacai Chen
2022-04-30 8:48 ` [PATCH V13 6/6] PCI: Add quirk for multifunction devices of LS7A Huacai Chen
2022-06-01 2:07 ` Bjorn Helgaas
2022-06-01 7:36 ` Jianmin Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601020806.GA793482@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).