Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Jim Quinlan <jim2101024@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Cyril Brulebois <kibi@debian.org>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	linux-pci <linux-pci@vger.kernel.org>,
	regressions@lists.linux.dev, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 0/4] PCI: brcmstb: Revert subdevice regulator stuff
Date: Tue, 21 Jun 2022 18:32:57 -0500	[thread overview]
Message-ID: <20220621233257.GA1342369@bhelgaas> (raw)
In-Reply-To: <CANCKTBtgZoXZikHVoLUVLGk04dzXYzdi-vdD-xaHnt0Z3BD45Q@mail.gmail.com>

On Tue, Jun 14, 2022 at 02:59:02PM -0400, Jim Quinlan wrote:
> ...

> The original patchset was and is controversial, as it is basically a
> square peg that does not fit nicely into a round Linux hole. It took
> 11 versions of following reviewers' suggestions until it was
> accepted.  And now it has been reverted, I am wondering if it will
> ever be let in again or whether I should even try.

The original patchset [1] may have been controversial, but that's not
the issue here.  The only thing we need to solve here is to post the
four patches I reverted with a tiny change to one of them to avoid the
regression.  I don't think that should be a problem.

Bjorn

[1] https://lore.kernel.org/r/20220106160332.2143-1-jim2101024@gmail.com

  reply	other threads:[~2022-06-21 23:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 20:18 [PATCH 0/4] PCI: brcmstb: Revert subdevice regulator stuff Bjorn Helgaas
2022-05-11 20:18 ` [PATCH 1/4] Revert "PCI: brcmstb: Do not turn off WOL regulators on suspend" Bjorn Helgaas
2022-05-12  6:24   ` Thorsten Leemhuis
2022-05-12 12:45     ` Bjorn Helgaas
2022-05-11 20:18 ` [PATCH 2/4] Revert "PCI: brcmstb: Add control of subdevice voltage regulators" Bjorn Helgaas
2022-05-11 20:18 ` [PATCH 3/4] Revert "PCI: brcmstb: Add mechanism to turn on subdev regulators" Bjorn Helgaas
2022-05-11 20:18 ` [PATCH 4/4] Revert "PCI: brcmstb: Split brcm_pcie_setup() into two funcs" Bjorn Helgaas
2022-05-11 20:24 ` [PATCH 0/4] PCI: brcmstb: Revert subdevice regulator stuff Florian Fainelli
2022-05-11 20:39   ` Cyril Brulebois
2022-05-11 20:54     ` Florian Fainelli
2022-05-11 20:39   ` Bjorn Helgaas
2022-06-13 17:06     ` Florian Fainelli
2022-06-14  0:00       ` Bjorn Helgaas
2022-06-14 16:16         ` Florian Fainelli
2022-06-14 18:59         ` Jim Quinlan
2022-06-21 23:32           ` Bjorn Helgaas [this message]
2022-06-27 23:18             ` Bjorn Helgaas
2022-07-01 11:25               ` Jim Quinlan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220621233257.GA1342369@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=jim2101024@gmail.com \
    --cc=kibi@debian.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=nsaenz@kernel.org \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox