From: Johan Hovold <johan+linaro@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Johan Hovold" <johan+linaro@kernel.org>
Subject: [PATCH 06/10] PCI: qcom: Add support for SC8280XP
Date: Wed, 29 Jun 2022 16:09:56 +0200 [thread overview]
Message-ID: <20220629141000.18111-7-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220629141000.18111-1-johan+linaro@kernel.org>
The SC8280XP platform has seven PCIe controllers: two used with USB4,
two 4-lane, two 2-lane and one 1-lane.
Add a new "qcom,pcie-sc8280xp" compatible string and reuse the 1.9.0
ops.
Note that the SC8280XP controllers need two or three interconnect
clocks to be enabled. Model these as optional clocks to avoid encoding
devicetree data in the PCIe driver.
Note that the same could be done for the SM8450 interconnect clocks and
possibly also for the TBU clocks.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/pci/controller/dwc/pcie-qcom.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index ff1b40f213c1..da3f1cdc4ba6 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -160,7 +160,7 @@ struct qcom_pcie_resources_2_3_3 {
/* 6 clocks typically, 7 for sm8250 */
struct qcom_pcie_resources_2_7_0 {
- struct clk_bulk_data clks[9];
+ struct clk_bulk_data clks[12];
int num_clks;
struct regulator_bulk_data supplies[2];
struct reset_control *pci_reset;
@@ -1119,6 +1119,7 @@ static int qcom_pcie_get_resources_2_7_0(struct qcom_pcie *pcie)
struct qcom_pcie_resources_2_7_0 *res = &pcie->res.v2_7_0;
struct dw_pcie *pci = pcie->pci;
struct device *dev = pci->dev;
+ unsigned int num_clks, num_opt_clks;
unsigned int idx;
int ret;
@@ -1148,9 +1149,20 @@ static int qcom_pcie_get_resources_2_7_0(struct qcom_pcie *pcie)
if (pcie->cfg->has_aggre1_clk)
res->clks[idx++].id = "aggre1";
+ num_clks = idx;
+
+ ret = devm_clk_bulk_get(dev, num_clks, res->clks);
+ if (ret < 0)
+ return ret;
+
+ res->clks[idx++].id = "noc_aggr_4";
+ res->clks[idx++].id = "noc_aggr_south_sf";
+ res->clks[idx++].id = "cnoc_qx";
+
+ num_opt_clks = idx - num_clks;
res->num_clks = idx;
- ret = devm_clk_bulk_get(dev, res->num_clks, res->clks);
+ ret = devm_clk_bulk_get_optional(dev, num_opt_clks, res->clks + num_clks);
if (ret < 0)
return ret;
@@ -1449,6 +1461,11 @@ static const struct qcom_pcie_cfg ipq4019_cfg = {
.ops = &ops_2_4_0,
};
+static const struct qcom_pcie_cfg sc8280xp_cfg = {
+ .ops = &ops_1_9_0,
+ .has_ddrss_sf_tbu_clk = true,
+};
+
static const struct qcom_pcie_cfg sdm845_cfg = {
.ops = &ops_2_7_0,
.has_tbu_clk = true,
@@ -1613,6 +1630,7 @@ static const struct of_device_id qcom_pcie_match[] = {
{ .compatible = "qcom,pcie-sm8150", .data = &sm8150_cfg },
{ .compatible = "qcom,pcie-sm8250", .data = &sm8250_cfg },
{ .compatible = "qcom,pcie-sc8180x", .data = &sc8180x_cfg },
+ { .compatible = "qcom,pcie-sc8280xp", .data = &sc8280xp_cfg },
{ .compatible = "qcom,pcie-sm8450-pcie0", .data = &sm8450_pcie0_cfg },
{ .compatible = "qcom,pcie-sm8450-pcie1", .data = &sm8450_pcie1_cfg },
{ .compatible = "qcom,pcie-sc7280", .data = &sc7280_cfg },
--
2.35.1
next prev parent reply other threads:[~2022-06-29 14:12 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 14:09 [PATCH 00/10] PCI: qcom: Add support for SC8280XP and SA8540P Johan Hovold
2022-06-29 14:09 ` [PATCH 01/10] dt-bindings: PCI: qcom: Fix reset conditional Johan Hovold
2022-06-29 14:37 ` Dmitry Baryshkov
2022-07-01 8:29 ` Krzysztof Kozlowski
2022-07-09 7:49 ` Manivannan Sadhasivam
2022-07-13 16:18 ` Bjorn Helgaas
2022-06-29 14:09 ` [PATCH 02/10] dt-bindings: PCI: qcom: Fix msi-interrupt conditional Johan Hovold
2022-06-29 14:37 ` Dmitry Baryshkov
2022-07-01 8:29 ` Krzysztof Kozlowski
2022-07-07 13:34 ` Dmitry Baryshkov
2022-07-07 13:41 ` Dmitry Baryshkov
2022-07-07 13:53 ` Johan Hovold
2022-07-09 7:50 ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 03/10] dt-bindings: PCI: qcom: Enumerate platforms with single msi interrupt Johan Hovold
2022-07-01 8:33 ` Krzysztof Kozlowski
2022-07-01 8:38 ` Johan Hovold
2022-07-01 18:38 ` Rob Herring
2022-07-04 14:21 ` Johan Hovold
2022-07-01 8:35 ` Krzysztof Kozlowski
2022-07-09 7:58 ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 04/10] dt-bindings: PCI: qcom: Add SC8280XP to binding Johan Hovold
2022-07-01 8:37 ` Krzysztof Kozlowski
2022-07-01 8:41 ` Johan Hovold
2022-07-09 8:00 ` Manivannan Sadhasivam
2022-07-11 9:36 ` Johan Hovold
2022-06-29 14:09 ` [PATCH 05/10] dt-bindings: PCI: qcom: Add SA8540P " Johan Hovold
2022-07-01 8:38 ` Krzysztof Kozlowski
2022-07-01 8:42 ` Johan Hovold
2022-07-09 8:02 ` Manivannan Sadhasivam
2022-07-11 9:38 ` Johan Hovold
2022-06-29 14:09 ` Johan Hovold [this message]
2022-07-01 18:29 ` [PATCH 06/10] PCI: qcom: Add support for SC8280XP Rob Herring
2022-07-04 14:10 ` Johan Hovold
2022-07-09 8:18 ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 07/10] PCI: qcom: Add support for SA8540P Johan Hovold
2022-07-01 18:29 ` Rob Herring
2022-07-09 8:19 ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 08/10] PCI: qcom: Make all optional clocks optional Johan Hovold
2022-07-01 18:34 ` Rob Herring
2022-07-09 8:23 ` Manivannan Sadhasivam
2022-06-29 14:09 ` [PATCH 09/10] PCI: qcom: Clean up IP configurations Johan Hovold
2022-07-01 18:35 ` Rob Herring
2022-07-09 8:25 ` Manivannan Sadhasivam
2022-06-29 14:10 ` [PATCH 10/10] PCI: qcom: Sort device-id table Johan Hovold
2022-07-01 8:40 ` Krzysztof Kozlowski
2022-07-01 8:46 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629141000.18111-7-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh+dt@kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).