From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CF08C433EF for ; Tue, 5 Jul 2022 22:40:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231151AbiGEWkh (ORCPT ); Tue, 5 Jul 2022 18:40:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbiGEWkg (ORCPT ); Tue, 5 Jul 2022 18:40:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 000D511C01; Tue, 5 Jul 2022 15:40:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 81A78B81A2F; Tue, 5 Jul 2022 22:40:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D10CEC341C7; Tue, 5 Jul 2022 22:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657060830; bh=hEbghLYblxH/UBauKCEXYAU5I1HKf00F59oiSCPkrcQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=f1DD5lKUgguyL6QxQirLzWNd8mln/EgZOqhXMseu1076pHC1+uGpHJVJAZ+qtMvJ1 MSxOBEmx9xLyp/Cl9KXdr+achMOVXmjO2jxWQboGXt7BpwgC0nn0PGfWXM2Hg4yqPc f2GLYEposMzq9iARoh+wUPT8YDFFszUeJjtkUk3adeJw0eFGR4G8s6GKNSqkw5W0cQ 8QKbGAedcxz1oV9fQCVyW1wPs5NjsU9hXPF/bZlNECcZhGlvhqQwuWpVt/OB0UydBK T2FyGB9Ty+7MN5F1UhirlTy0hf07sTBs1BxvcUrALv6PlXx8OmQ0J/m1SpumTNCwIQ xyUDLxhg8SAjg== Date: Tue, 5 Jul 2022 17:40:28 -0500 From: Bjorn Helgaas To: Shunsuke Mie Cc: Kishon Vijay Abraham I , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Hou Zhiqiang , Li Chen , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: endpoint: Don't stop EP controller by EP function Message-ID: <20220705224028.GA90560@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622040924.113279-1-mie@igel.co.jp> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Jun 22, 2022 at 01:09:24PM +0900, Shunsuke Mie wrote: > For multi-function endpoint device, an ep function shouldn't stop EP > controller. Nomally the controller is stopped via configfs. Can you please clarify this for me? An endpoint function by itself wouldn't stop an endpoint controller. I assume that some *operation* on an endpoint function currently stops the endpoint controller, but that operation should not stop the controller? I guess the operation is an "unbind" that detaches an EPF device from an EPC device? > Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to test PCI") > Signed-off-by: Shunsuke Mie > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 5b833f00e980..a5ed779b0a51 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -627,7 +627,6 @@ static void pci_epf_test_unbind(struct pci_epf *epf) > > cancel_delayed_work(&epf_test->cmd_handler); > pci_epf_test_clean_dma_chan(epf_test); > - pci_epc_stop(epc); > for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { > epf_bar = &epf->bar[bar]; > > -- > 2.17.1 >