From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/doc: Convert examples to generic power management
Date: Mon, 11 Jul 2022 18:19:18 -0500 [thread overview]
Message-ID: <20220711231918.GA707416@bhelgaas> (raw)
In-Reply-To: <20220607232946.355987-1-helgaas@kernel.org>
[+cc Jonathan, linux-doc, linux-kernel; sorry I missed you earlier]
On Tue, Jun 07, 2022 at 06:29:46PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> PCI-specific power management (pci_driver.suspend and pci_driver.resume) is
> deprecated. Convert sample code to the generic power management framework.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
I applied this to pci/pm for v5.20. Let me know if you object!
> ---
> Documentation/PCI/pci-iov-howto.rst | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/PCI/pci-iov-howto.rst b/Documentation/PCI/pci-iov-howto.rst
> index b9fd003206f1..27d35933cea2 100644
> --- a/Documentation/PCI/pci-iov-howto.rst
> +++ b/Documentation/PCI/pci-iov-howto.rst
> @@ -125,14 +125,14 @@ Following piece of code illustrates the usage of the SR-IOV API.
> ...
> }
>
> - static int dev_suspend(struct pci_dev *dev, pm_message_t state)
> + static int dev_suspend(struct device *dev)
> {
> ...
>
> return 0;
> }
>
> - static int dev_resume(struct pci_dev *dev)
> + static int dev_resume(struct device *dev)
> {
> ...
>
> @@ -165,8 +165,7 @@ Following piece of code illustrates the usage of the SR-IOV API.
> .id_table = dev_id_table,
> .probe = dev_probe,
> .remove = dev_remove,
> - .suspend = dev_suspend,
> - .resume = dev_resume,
> + .driver.pm = &dev_pm_ops,
> .shutdown = dev_shutdown,
> .sriov_configure = dev_sriov_configure,
> };
> --
> 2.25.1
>
prev parent reply other threads:[~2022-07-11 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 23:29 [PATCH] PCI/doc: Convert examples to generic power management Bjorn Helgaas
2022-07-11 23:19 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711231918.GA707416@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).