From: Bjorn Helgaas <helgaas@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: "Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: qcom: Add support for modular builds
Date: Fri, 15 Jul 2022 11:56:01 -0500 [thread overview]
Message-ID: <20220715165601.GA1139849@bhelgaas> (raw)
In-Reply-To: <9ef036db-2ac8-2723-93de-ac841d94ba51@linaro.org>
On Thu, Jul 14, 2022 at 04:05:41PM +0300, Dmitry Baryshkov wrote:
> On 14/07/2022 15:19, Stanimir Varbanov wrote:
> > Please take a look why we made it built-in first [1].
> >
> > If arguments there are still valid I don't see why to make it a module
> > again.
> >
> > [1] https://lkml.org/lkml/2016/8/24/694
>
> It looks like there is a move to make all non-essential drivers buildable as
> modules. For example, the Kirin, dra7xx, Meson PCI controllers are now
> buildable as modules. So I think we can follow that and allow building the
> pcie-qcom as a module.
IIUC the arguments in [1] are that:
- Kconfig is bool, so it can't be built as a module
- there's no sensible use case for unbind
Those described the situation at the time, and there's no point in
having .remove() and using module_platform_driver() if Kconfig is
bool.
But they don't seem like arguments for why the driver couldn't be
*made* modular.
I think drivers *should* be modular unless there's a technical reason
they can't be.
Bjorn
next prev parent reply other threads:[~2022-07-15 16:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 9:46 [PATCH] PCI: qcom: Add support for modular builds Johan Hovold
2022-05-26 20:53 ` Rob Herring
2022-06-23 11:40 ` Johan Hovold
2022-06-23 15:52 ` Bjorn Helgaas
2022-06-27 7:31 ` Johan Hovold
2022-07-14 12:19 ` Stanimir Varbanov
2022-07-14 13:05 ` Dmitry Baryshkov
2022-07-15 16:56 ` Bjorn Helgaas [this message]
2022-07-18 7:43 ` Stanimir Varbanov
2022-07-14 13:10 ` Johan Hovold
2022-07-20 16:27 ` Manivannan Sadhasivam
2022-07-20 21:20 ` Bjorn Helgaas
2022-07-21 6:51 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715165601.GA1139849@bhelgaas \
--to=helgaas@kernel.org \
--cc=agross@kernel.org \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).