From: Bjorn Helgaas <helgaas@kernel.org>
To: Jim Quinlan <jim2101024@gmail.com>
Cc: linux-pci@vger.kernel.org,
"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Cyril Brulebois" <kibi@debian.org>,
bcm-kernel-feedback-list@broadcom.com,
james.quinlan@broadcom.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/6] PCI: brcmstb: Split brcm_pcie_setup() into two funcs
Date: Mon, 18 Jul 2022 17:40:33 -0500 [thread overview]
Message-ID: <20220718224033.GA1450714@bhelgaas> (raw)
In-Reply-To: <20220718181425.GA1431580@bhelgaas>
On Mon, Jul 18, 2022 at 01:14:25PM -0500, Bjorn Helgaas wrote:
> ...
> So I think brcm_pcie_setup() does initialization that doesn't depend
> on the link or any downstream devices, and brcm_pcie_start_link() does
> things that depend on the link being up. Right?
>
> If so, "start_link" might be a slight misnomer since AFAICT
> brcm_pcie_start_link() doesn't do anything to initiate link-up except
> maybe deasserting fundamental reset. Some drivers start the LTSSM or
> explicitly enable link training, but brcm_pcie_start_link() doesn't
> seem to do anything like that.
>
> brcm_pcie_start_link() still does brcm_pcie_set_outbound_win(). Does
> that really depend on the link being up? If that only affects the
> Root Port, maybe it could be done before link-up?
What about the /* PCIe->SCB endian mode for BAR */ thing? Does that
depend on the link being up?
And the "Refclk from RC should be gated with CLKREQ#" part? Does that
depend on the link being up?
It seems obvious that brcm_pcie_set_ssc() and reading the negotiated
link speed and width depend on the link being up.
next prev parent reply other threads:[~2022-07-18 22:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 22:24 [PATCH v2 0/6] PCI: brcmstb: Re-submit reverted patchset Jim Quinlan
2022-07-16 22:24 ` [PATCH v2 1/6] PCI: brcmstb: Remove unnecessary forward declarations Jim Quinlan
2022-07-16 22:24 ` [PATCH v2 2/6] PCI: brcmstb: Split brcm_pcie_setup() into two funcs Jim Quinlan
2022-07-18 13:11 ` Pali Rohár
2022-07-18 13:37 ` Jim Quinlan
2022-07-18 17:05 ` Bjorn Helgaas
2022-07-18 18:01 ` Pali Rohár
2022-07-18 18:14 ` Bjorn Helgaas
2022-07-18 18:56 ` Jim Quinlan
2022-07-18 19:23 ` Bjorn Helgaas
2022-07-18 22:40 ` Bjorn Helgaas
2022-07-19 13:08 ` Jim Quinlan
2022-07-19 20:03 ` Bjorn Helgaas
2022-07-20 14:53 ` Jim Quinlan
2022-07-20 16:18 ` Rob Herring
2022-07-20 21:34 ` Florian Fainelli
2022-07-21 14:27 ` Rob Herring
2022-07-18 22:40 ` Bjorn Helgaas [this message]
2022-07-20 20:37 ` Bjorn Helgaas
2022-07-21 14:56 ` Jim Quinlan
2022-07-21 16:10 ` Bjorn Helgaas
2022-07-16 22:24 ` [PATCH v2 3/6] PCI: brcmstb: Add "refusal mode" to preclude PCIe-induced CPU aborts Jim Quinlan
2022-07-20 22:05 ` Bjorn Helgaas
2022-07-21 14:53 ` Jim Quinlan
2022-07-21 15:46 ` Bjorn Helgaas
2022-07-20 22:08 ` Bjorn Helgaas
2022-07-16 22:24 ` [PATCH v2 4/6] PCI: brcmstb: Add mechanism to turn on subdev regulators Jim Quinlan
2022-07-16 22:24 ` [PATCH v2 5/6] PCI: brcmstb: Add control of subdevice voltage regulators Jim Quinlan
2022-07-16 22:24 ` [PATCH v2 6/6] PCI: brcmstb: Do not turn off WOL regulators on suspend Jim Quinlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718224033.GA1450714@bhelgaas \
--to=helgaas@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=jim2101024@gmail.com \
--cc=kibi@debian.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lpieralisi@kernel.org \
--cc=nsaenz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).