From: Bjorn Helgaas <helgaas@kernel.org>
To: Andrey Strachuk <strochuk@ispras.ru>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] ACPI: remove useless comparisons in acpi_pci_link_check_possible(), acpi_pci_link_check_current()
Date: Tue, 19 Jul 2022 15:46:32 -0500 [thread overview]
Message-ID: <20220719204632.GA1562909@bhelgaas> (raw)
In-Reply-To: <20220719095950.5420-1-strochuk@ispras.ru>
Since this only affects pci_link.c, I would update the subject to
match the style of previous commits:
ACPI/PCI: Remove useless NULL pointer checks
On Tue, Jul 19, 2022 at 12:59:50PM +0300, Andrey Strachuk wrote:
> Local variable 'p' is initialized by an address
> of field of acpi_resource, so it does not make
> sense to compare 'p' with NULL.
Rewrap to fill 75 columns, which is the typical width of commit logs.
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Strachuk <strochuk@ispras.ru>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
I think you should drop this Fixes: tag because it's not useful.
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/acpi/pci_link.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> index 58647051c948..aa1038b8aec4 100644
> --- a/drivers/acpi/pci_link.c
> +++ b/drivers/acpi/pci_link.c
> @@ -95,7 +95,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,
> case ACPI_RESOURCE_TYPE_IRQ:
> {
> struct acpi_resource_irq *p = &resource->data.irq;
> - if (!p || !p->interrupt_count) {
> + if (!p->interrupt_count) {
> acpi_handle_debug(handle,
> "Blank _PRS IRQ resource\n");
> return AE_OK;
> @@ -121,7 +121,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,
> {
> struct acpi_resource_extended_irq *p =
> &resource->data.extended_irq;
> - if (!p || !p->interrupt_count) {
> + if (!p->interrupt_count) {
> acpi_handle_debug(handle,
> "Blank _PRS EXT IRQ resource\n");
> return AE_OK;
> @@ -182,7 +182,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,
> case ACPI_RESOURCE_TYPE_IRQ:
> {
> struct acpi_resource_irq *p = &resource->data.irq;
> - if (!p || !p->interrupt_count) {
> + if (!p->interrupt_count) {
> /*
> * IRQ descriptors may have no IRQ# bits set,
> * particularly those w/ _STA disabled
> @@ -197,7 +197,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,
> {
> struct acpi_resource_extended_irq *p =
> &resource->data.extended_irq;
> - if (!p || !p->interrupt_count) {
> + if (!p->interrupt_count) {
> /*
> * extended IRQ descriptors must
> * return at least 1 IRQ
> --
> 2.25.1
>
prev parent reply other threads:[~2022-07-19 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 9:59 [PATCH] ACPI: remove useless comparisons in acpi_pci_link_check_possible(), acpi_pci_link_check_current() Andrey Strachuk
2022-07-19 20:46 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719204632.GA1562909@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=ldv-project@linuxtesting.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=strochuk@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).