From: Bjorn Helgaas <helgaas@kernel.org>
To: Paul Walmsley <paul.walmsley@sifive.com>,
Greentime Hu <greentime.hu@sifive.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: fu740: Remove unnecessary include files
Date: Wed, 20 Jul 2022 17:49:53 -0500 [thread overview]
Message-ID: <20220720224953.GA1667223@bhelgaas> (raw)
In-Reply-To: <20220719173321.1545451-1-helgaas@kernel.org>
On Tue, Jul 19, 2022 at 12:33:21PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> fu740 uses no syscon or regman interfaces, so it doesn't need to include
> mfs/syscon.h. It uses no regulator interfaces, so it doesn't need to
> include regulator/consumer.h either.
>
> Remove both unnecessary includes.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Applied to pci/ctrl/fu740 for v5.20. Let me know if you object.
> ---
> drivers/pci/controller/dwc/pcie-fu740.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
> index 02cc70d8cc06..e8b008f73f34 100644
> --- a/drivers/pci/controller/dwc/pcie-fu740.c
> +++ b/drivers/pci/controller/dwc/pcie-fu740.c
> @@ -16,11 +16,9 @@
> #include <linux/gpio.h>
> #include <linux/gpio/consumer.h>
> #include <linux/kernel.h>
> -#include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> #include <linux/platform_device.h>
> -#include <linux/regulator/consumer.h>
> #include <linux/resource.h>
> #include <linux/types.h>
> #include <linux/interrupt.h>
> --
> 2.25.1
>
prev parent reply other threads:[~2022-07-20 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 17:33 [PATCH] PCI: fu740: Remove unnecessary include files Bjorn Helgaas
2022-07-20 22:49 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720224953.GA1667223@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=greentime.hu@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).