From: Bjorn Helgaas <helgaas@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Xiaowei Song <songxiaowei@hisilicon.com>,
Binghui Wang <wangbinghui@hisilicon.com>,
Thierry Reding <thierry.reding@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Jianjun Wang <jianjun.wang@mediatek.com>
Cc: linux-pci@vger.kernel.org, "Tom Joseph" <tjoseph@cadence.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Pali Rohár" <pali@kernel.org>,
"Ley Foon Tan" <ley.foon.tan@intel.com>,
linux-kernel@vger.kernel.org
Subject: Why set .suppress_bind_attrs even though .remove() implemented?
Date: Thu, 21 Jul 2022 14:54:33 -0500 [thread overview]
Message-ID: <20220721195433.GA1747571@bhelgaas> (raw)
The j721e, kirin, tegra, and mediatek drivers all implement .remove().
They also set ".suppress_bind_attrs = true". I think this means
bus_add_driver() will not create the "bind" and "unbind" sysfs
attributes for the driver that would allow users to users to manually
attach and detach devices from it.
Is there a reason for this, or should these drivers stop setting
.suppress_bind_attrs?
For example, Pali and Ley Foon *did* stop setting .suppress_bind_attrs
when adding .remove() methods in these commits:
0746ae1be121 ("PCI: mvebu: Add support for compiling driver as module")
526a76991b7b ("PCI: aardvark: Implement driver 'remove' function and allow to build it as module")
ec15c4d0d5d2 ("PCI: altera: Allow building as module")
Bjorn
next reply other threads:[~2022-07-21 19:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 19:54 Bjorn Helgaas [this message]
2022-07-21 20:46 ` Why set .suppress_bind_attrs even though .remove() implemented? Pali Rohár
2022-07-21 20:48 ` Conor.Dooley
2022-07-21 22:21 ` Bjorn Helgaas
2022-07-21 22:48 ` Pali Rohár
2022-07-22 13:26 ` Johan Hovold
2022-07-22 14:38 ` Bjorn Helgaas
2022-07-25 13:25 ` Johan Hovold
2022-07-25 14:43 ` Marc Zyngier
2022-07-25 15:18 ` Johan Hovold
2022-07-25 17:35 ` Marc Zyngier
2022-07-26 9:56 ` Johan Hovold
2022-07-27 19:57 ` Bjorn Helgaas
2022-07-28 12:17 ` Johan Hovold
2024-10-17 5:23 ` Manivannan Sadhasivam
2024-10-17 7:50 ` Marc Zyngier
2024-10-17 8:25 ` Manivannan Sadhasivam
2024-10-17 8:48 ` Marc Zyngier
2024-10-17 9:30 ` Manivannan Sadhasivam
2024-10-17 9:56 ` Marc Zyngier
2022-09-27 15:27 ` Lorenzo Pieralisi
2022-09-28 6:36 ` Johan Hovold
2022-07-22 14:39 ` Bjorn Helgaas
2022-07-22 17:06 ` Marc Zyngier
2022-07-22 17:17 ` Bjorn Helgaas
2022-07-24 9:38 ` Marc Zyngier
2022-07-25 20:18 ` Florian Fainelli
2022-07-25 17:49 ` Conor.Dooley
2022-07-26 7:26 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721195433.GA1747571@bhelgaas \
--to=helgaas@kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=ley.foon.tan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pali@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=songxiaowei@hisilicon.com \
--cc=thierry.reding@gmail.com \
--cc=tjoseph@cadence.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox