From: Stephen Hemminger <stephen@networkplumber.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
bhelgaas@google.com, gregkh@linuxfoundation.org,
linux-pci@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [REGRESSION] changes to driver_override parsing broke DPDK script
Date: Wed, 10 Aug 2022 07:03:44 -0700 [thread overview]
Message-ID: <20220810070344.1701f4a6@hermes.local> (raw)
In-Reply-To: <28388e27-e562-65cd-4663-977ea4ad51a0@linaro.org>
On Wed, 10 Aug 2022 09:13:40 +0300
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 10/08/2022 08:54, Krzysztof Kozlowski wrote:
> > On 09/08/2022 22:21, Bjorn Helgaas wrote:
> >> [+cc regressions list]
> >>
> >> 23d99baf9d72 appeared in v5.19-rc1.
> >>
> >> On Tue, Aug 09, 2022 at 11:29:43AM -0700, Stephen Hemminger wrote:
> >>> This commit broke the driver override script in DPDK.
> >>> This is an API/ABI breakage, please revert or fix the commit.
> >>>
> >>> Report of problem:
> >>> http://mails.dpdk.org/archives/dev/2022-August/247794.html
> >
> > Thanks for the report. I'll take a look.
> >
>
> I could not find in the report (neither here) steps to reproduce it. Can
> you provide me some short description (what kernel options are required,
> what commands to run)?
>
> I tried to run:
> $ usertools/dpdk-devbind.py --status
> $ usertools/dpdk-devbind.py --bind '0000:00:03.0'
> Error: No devices specified.
>
>
> Best regards,
> Krzysztof
To test, you need to be willing to have one network device disappear from
kernel. The bug is in the unbind step this is an example of it working
with 5.17 kernel.
~/DPDK/main $ ./usertools/dpdk-devbind.py --status
Network devices using kernel driver
===================================
0000:01:00.0 'Wi-Fi 6 AX200 2723' if=wlo1 drv=iwlwifi unused=
0000:02:00.0 'RTL8125 2.5GbE Controller 8125' if=enp2s0 drv=r8169 unused= *Active*
~/DPDK/main $ sudo modprobe vfio-pci
~/DPDK/main $ sudo ./usertools/dpdk-devbind.py --bind=vfio-pci enp2s0
Warning: routing table indicates that interface 0000:02:00.0 is active. Not modifying
~/DPDK/main $ ip li set dev enp2s0 down
RTNETLINK answers: Operation not permitted
~/DPDK/main $ sudo ip li set dev enp2s0 down
~/DPDK/main $ sudo ./usertools/dpdk-devbind.py --bind=vfio-pci enp2s0
~/DPDK/main $ ./usertools/dpdk-devbind.py --status
Network devices using DPDK-compatible driver
============================================
0000:02:00.0 'RTL8125 2.5GbE Controller 8125' drv=vfio-pci unused=r8169
Network devices using kernel driver
===================================
0000:01:00.0 'Wi-Fi 6 AX200 2723' if=wlo1 drv=iwlwifi unused=vfio-pci
~/DPDK/main $ sudo ./usertools/dpdk-devbind.py -u 0000:02:00.0
~/DPDK/main $ ./usertools/dpdk-devbind.py --status
Network devices using kernel driver
===================================
0000:01:00.0 'Wi-Fi 6 AX200 2723' if=wlo1 drv=iwlwifi unused=vfio-pci
Other Network devices
=====================
0000:02:00.0 'RTL8125 2.5GbE Controller 8125' unused=r8169,vfio-pci
next prev parent reply other threads:[~2022-08-10 14:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 18:29 [REGRESSION] changes to driver_override parsing broke DPDK script Stephen Hemminger
2022-08-09 19:21 ` Bjorn Helgaas
2022-08-10 5:54 ` Krzysztof Kozlowski
2022-08-10 6:11 ` Greg KH
2022-08-10 8:21 ` Greg KH
2022-08-12 1:48 ` Dongdong Liu
2022-08-12 2:54 ` lihuisong (C)
2022-08-12 5:46 ` Greg KH
2022-09-01 16:41 ` Greg KH
2022-08-10 6:13 ` Krzysztof Kozlowski
2022-08-10 14:03 ` Stephen Hemminger [this message]
2022-08-10 14:06 ` Stephen Hemminger
2022-08-10 5:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810070344.1701f4a6@hermes.local \
--to=stephen@networkplumber.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-pci@vger.kernel.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox