From: Rob Herring <robh@kernel.org>
To: Will McVicker <willmcvicker@google.com>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
kernel-team@android.com, "Vidya Sagar" <vidyas@nvidia.com>,
"kernel test robot" <lkp@intel.com>,
"Isaac J . Manjarres" <isaacmanjarres@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: dwc: add support for 64-bit MSI target address
Date: Wed, 10 Aug 2022 15:30:23 -0600 [thread overview]
Message-ID: <20220810213023.GB557589-robh@kernel.org> (raw)
In-Reply-To: <20220810183536.1630940-3-willmcvicker@google.com>
On Wed, Aug 10, 2022 at 06:35:35PM +0000, Will McVicker wrote:
> Since not all devices require a 32-bit MSI address, add support to the
> PCIe host driver to allow setting the DMA mask to 64-bits. This allows
> kernels to disable ZONE_DMA32 and bounce buffering (swiotlb) without
> risking not being able to get a 32-bit address during DMA allocation.
> Basically, in the slim chance that there are no 32-bit allocations
> available, the current PCIe host driver will fail to allocate the
> msi_msg page due to a DMA address overflow (seen in [1]). With this
> patch, the PCIe driver can advertise 64-bit support via it's MSI
> capabilities to hint to the PCIe host driver to set the DMA mask to
> 64-bits.
>
> [1] https://lore.kernel.org/all/Yo0soniFborDl7+C@google.com/
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Will McVicker <willmcvicker@google.com>
> ---
> drivers/pci/controller/dwc/pcie-designware-host.c | 14 ++++++++++++--
> drivers/pci/controller/dwc/pcie-designware.c | 9 +++++++++
> drivers/pci/controller/dwc/pcie-designware.h | 1 +
> 3 files changed, 22 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2022-08-10 21:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 18:35 [PATCH v2 0/2] PCI: dwc: Add support for 64-bit MSI target addresses Will McVicker
2022-08-10 18:35 ` [PATCH v2 1/2] PCI: dwc: drop dependency on ZONE_DMA32 Will McVicker
2022-08-10 21:27 ` Rob Herring
2022-08-10 23:09 ` William McVicker
2022-08-10 18:35 ` [PATCH v2 2/2] PCI: dwc: add support for 64-bit MSI target address Will McVicker
2022-08-10 21:30 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810213023.GB557589-robh@kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=isaacmanjarres@google.com \
--cc=jingoohan1@gmail.com \
--cc=kernel-team@android.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=vidyas@nvidia.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).