From: kernel test robot <lkp@intel.com>
To: "Will McVicker" <willmcvicker@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <helgaas@kernel.org>
Cc: kbuild-all@lists.01.org, kernel-team@android.com,
Vidya Sagar <vidyas@nvidia.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] PCI: dwc: add support for 64-bit MSI target address
Date: Thu, 11 Aug 2022 01:18:42 +0800 [thread overview]
Message-ID: <202208110116.R0hD7l2c-lkp@intel.com> (raw)
In-Reply-To: <20220809180051.1063653-3-willmcvicker@google.com>
Hi Will,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on linus/master next-20220810]
[cannot apply to v5.19]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Will-McVicker/PCI-dwc-Add-support-for-64-bit-MSI-target-addresses/20220810-020421
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: sparc-buildonly-randconfig-r004-20220810 (https://download.01.org/0day-ci/archive/20220811/202208110116.R0hD7l2c-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7a41faa4e02a0a8945f79e7af86d10e371b2fc12
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Will-McVicker/PCI-dwc-Add-support-for-64-bit-MSI-target-addresses/20220810-020421
git checkout 7a41faa4e02a0a8945f79e7af86d10e371b2fc12
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/pci/controller/dwc/pcie-designware.c:85:5: error: redefinition of 'dw_pcie_msi_capabilities'
85 | u16 dw_pcie_msi_capabilities(struct dw_pcie *pci)
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/pci/controller/dwc/pcie-designware.c:20:
drivers/pci/controller/dwc/pcie-designware.h:467:19: note: previous definition of 'dw_pcie_msi_capabilities' with type 'u16(struct dw_pcie *)' {aka 'short unsigned int(struct dw_pcie *)'}
467 | static inline u16 dw_pcie_msi_capabilities(struct dw_pcie *pci)
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/dw_pcie_msi_capabilities +85 drivers/pci/controller/dwc/pcie-designware.c
84
> 85 u16 dw_pcie_msi_capabilities(struct dw_pcie *pci)
86 {
87 u8 offset;
88
89 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI);
90 return dw_pcie_readw_dbi(pci, offset + PCI_MSI_FLAGS);
91 }
92 EXPORT_SYMBOL_GPL(dw_pcie_msi_capabilities);
93
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-08-10 17:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 18:00 [PATCH v1 0/2] PCI: dwc: Add support for 64-bit MSI target addresses Will McVicker
2022-08-09 18:00 ` [PATCH v1 1/2] PCI: dwc: drop dependency on ZONE_DMA32 Will McVicker
2022-08-11 9:20 ` Christoph Hellwig
2022-08-11 16:38 ` William McVicker
2022-08-09 18:00 ` [PATCH v1 2/2] PCI: dwc: add support for 64-bit MSI target address Will McVicker
2022-08-10 17:18 ` kernel test robot [this message]
2022-08-11 9:22 ` Christoph Hellwig
2022-08-11 16:36 ` William McVicker
2022-08-11 12:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208110116.R0hD7l2c-lkp@intel.com \
--to=lkp@intel.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=helgaas@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel-team@android.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=vidyas@nvidia.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).