From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: kishon@ti.com, lpieralisi@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, mie@igel.co.jp, kw@linux.com
Subject: Re: [PATCH 2/5] misc: pci_endpoint_test: Fix the return value of IOCTL
Date: Sat, 20 Aug 2022 17:35:20 +0530 [thread overview]
Message-ID: <20220820120520.GD3151@thinkpad> (raw)
In-Reply-To: <Yv+qSDUEs+6T8b9+@kroah.com>
On Fri, Aug 19, 2022 at 05:20:40PM +0200, Greg KH wrote:
> On Fri, Aug 19, 2022 at 08:20:15PM +0530, Manivannan Sadhasivam wrote:
> > IOCTLs are supposed to return 0 for success and negative error codes for
> > failure. Currently, this driver is returning 0 for failure and 1 for
> > success, that's not correct. Hence, fix it!
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> This needs to come first in the series,
Yeah, I thought about that but then I had one more patch touching this driver
and if this comes first then that patch should be at 4/5. I was not sure if
that's fine since two patches touching the same driver would be at different
positions in a series.
Anyway, since you said, I'll just move this to 1/5 and other one to 4/5.
> along with a Fixes: tag, and a
> cc: stable tag so that it can be properly backported and fixed up
> everywhere.
>
Okay.
Thanks,
Mani
> thanks,
>
> greg k-h
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-08-20 12:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 14:50 [PATCH 0/5] pci_endpoint_test: Fix the return value of IOCTLs Manivannan Sadhasivam
2022-08-19 14:50 ` [PATCH 1/5] misc: pci_endpoint_test: Remove unnecessary WARN_ON Manivannan Sadhasivam
2022-08-19 15:27 ` Greg KH
2022-08-20 11:46 ` Manivannan Sadhasivam
2022-08-19 14:50 ` [PATCH 2/5] misc: pci_endpoint_test: Fix the return value of IOCTL Manivannan Sadhasivam
2022-08-19 15:20 ` Greg KH
2022-08-20 12:05 ` Manivannan Sadhasivam [this message]
2022-08-19 15:25 ` Greg KH
2022-08-20 12:01 ` Manivannan Sadhasivam
2022-08-19 14:50 ` [PATCH 3/5] tools: PCI: Fix parsing the return value of IOCTLs Manivannan Sadhasivam
2022-08-19 15:27 ` Greg KH
2022-08-20 11:47 ` Manivannan Sadhasivam
2022-08-22 4:25 ` Shunsuke Mie
2022-08-19 14:50 ` [PATCH 4/5] tools: PCI: Fix memory leak Manivannan Sadhasivam
2022-08-19 14:50 ` [PATCH 5/5] Documentation: PCI: endpoint: Use the correct return value of pcitest.sh Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220820120520.GD3151@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mie@igel.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).