Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Alex Deucher <alexander.deucher@amd.com>
To: <amd-gfx@lists.freedesktop.org>, <helgaas@kernel.org>
Cc: <regressions@lists.linux.dev>, <airlied@linux.ie>,
	<linux-pci@vger.kernel.org>, <tseewald@gmail.com>,
	<kai.heng.feng@canonical.com>, <daniel@ffwll.ch>, <sr@denx.de>,
	<m.seyfarth@gmail.com>, Alex Deucher <alexander.deucher@amd.com>,
	Lijo Lazar <lijo.lazar@amd.com>
Subject: [PATCH 4/7] drm/amdgpu: add HDP remap functionality to nbio 7.7
Date: Fri, 9 Sep 2022 12:47:55 -0400	[thread overview]
Message-ID: <20220909164758.5632-5-alexander.deucher@amd.com> (raw)
In-Reply-To: <20220909164758.5632-1-alexander.deucher@amd.com>

Was missing before and would have resulted in a write to
a non-existant register. Normally APUs don't use HDP, but
other asics could use this code and APUs do use the HDP
when used in passthrough.

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c
index f30bc826a878..def89379b51a 100644
--- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c
+++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_7.c
@@ -28,6 +28,14 @@
 #include "nbio/nbio_7_7_0_sh_mask.h"
 #include <uapi/linux/kfd_ioctl.h>
 
+static void nbio_v7_7_remap_hdp_registers(struct amdgpu_device *adev)
+{
+	WREG32_SOC15(NBIO, 0, regBIF_BX0_REMAP_HDP_MEM_FLUSH_CNTL,
+		     adev->rmmio_remap.reg_offset + KFD_MMIO_REMAP_HDP_MEM_FLUSH_CNTL);
+	WREG32_SOC15(NBIO, 0, regBIF_BX0_REMAP_HDP_REG_FLUSH_CNTL,
+		     adev->rmmio_remap.reg_offset + KFD_MMIO_REMAP_HDP_REG_FLUSH_CNTL);
+}
+
 static u32 nbio_v7_7_get_rev_id(struct amdgpu_device *adev)
 {
 	u32 tmp;
@@ -336,4 +344,5 @@ const struct amdgpu_nbio_funcs nbio_v7_7_funcs = {
 	.get_clockgating_state = nbio_v7_7_get_clockgating_state,
 	.ih_control = nbio_v7_7_ih_control,
 	.init_registers = nbio_v7_7_init_registers,
+	.remap_hdp_registers = nbio_v7_7_remap_hdp_registers,
 };
-- 
2.37.2


  parent reply	other threads:[~2022-09-09 16:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 16:47 [PATCH 0/7] fix PCI AER issues Alex Deucher
2022-09-09 16:47 ` [PATCH 1/7] drm/amdgpu: move nbio remap_hdp_registers() to gmc9 code Alex Deucher
2022-09-09 17:17   ` Lazar, Lijo
2022-09-09 17:35     ` Alex Deucher
2022-09-12  4:41       ` Lazar, Lijo
2022-09-09 16:47 ` [PATCH 2/7] drm/amdgpu: move nbio remap_hdp_registers() to gmc10 code Alex Deucher
2022-09-09 16:47 ` [PATCH 3/7] drm/amdgpu: move nbio remap_hdp_registers() to gmc11 code Alex Deucher
2022-09-09 16:47 ` Alex Deucher [this message]
2022-09-09 16:47 ` [PATCH 5/7] drm/amdgpu: move nbio ih_doorbell_range() into ih code for vega Alex Deucher
2022-09-09 16:47 ` [PATCH 6/7] drm/amdgpu: move nbio sdma_doorbell_range() into sdma " Alex Deucher
2022-09-09 16:47 ` [PATCH 7/7] drm/amdgpu: make sure to init common IP before gmc Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220909164758.5632-5-alexander.deucher@amd.com \
    --to=alexander.deucher@amd.com \
    --cc=airlied@linux.ie \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=helgaas@kernel.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=lijo.lazar@amd.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=m.seyfarth@gmail.com \
    --cc=regressions@lists.linux.dev \
    --cc=sr@denx.de \
    --cc=tseewald@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox