Re: [PATCH v3 02/12] PCI: qcom-ep: Do not use hardcoded clks in driver

Manivannan Sadhasivam
2022-09-14T06:05:17Z

On Tue, Sep 13, 2022 at 03:12:56PM -0500, Bjorn Helgaas wrote:
> On Sat, Sep 10, 2022 at 12:00:35PM +0530, Manivannan Sadhasivam wrote:
> > Generally, device drivers should just rely on the platform data like
> > devicetree to supply the clocks required for the functioning of the
> > peripheral. There is no need to hardcode the clk info in the driver.
> > So get rid of the static clk info and obtain the platform supplied
> > clks.
>
> Possibly reword the subject line to say what this does instead of what
> it does not do? E.g., "Rely on devicetree 'clock-names' instead of
> hard-coding" or whatever.
>

Okay.

Thanks,
Mani

> Bjorn