Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging

Bjorn Helgaas
2022-10-18T16:43:35Z

On Tue, Oct 18, 2022 at 07:21:54AM +0100, Jon Hunter wrote:
> Hi Bjorn,
>
> On 13/09/2022 11:12, Vidya Sagar wrote:
> > Some of the platforms (like Tegra194 and Tegra234) have open slots and
> > not having an endpoint connected to the slot is not an error.
> > So, changing the macro from dev_err to dev_info to log the event.
> >
> > Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > ---
> > drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> > index 650a7f22f9d0..25154555aa7a 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > @@ -456,7 +456,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
> > }
> > if (retries >= LINK_WAIT_MAX_RETRIES) {
> > - dev_err(pci->dev, "Phy link never came up\n");
> > + dev_info(pci->dev, "Phy link never came up\n");
> > return -ETIMEDOUT;
> > }
>
>
> Are you OK to take this change?

When this came up, Lorenzo was in the middle of a big move and I was
covering for him while he was unavailable. But he's back, and I'm
sure he will resolve this soon.

Personally I'm OK either way.

Bjorn