Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging

Manivannan Sadhasivam
2022-09-14T13:46:00Z

On Wed, Sep 14, 2022 at 09:44:44PM +0900, Krzysztof Wilczyński wrote:
> Hello,
>
> [...]
> > Anyway, I don't strongly object the change and leave it to the
> > maintainers to decide.
>
> Perhaps it makes sense to make this a dev_dbg() over dev_info(), especially
> since it appears that this information is of more use to the developer (who
> most likely has the suitable log level set anyway), and given that there is
> no way to reliably detect a presence in a slot on some platforms, this
> might otherwise, add to the other messages that normal users don't pay
> attention to usually - if this is not to be treated as an error.
>

No, this is clearly not a debug message. As I quoted above, the link up
can fail due to an issue with PHY also. In that case, user has to see
the log to debug/report the issue.

So, either dev_info() or dev_err().

Thanks,
Mani

> Krzysztof