From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9217ECAAD8 for ; Wed, 14 Sep 2022 06:13:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbiINGNo (ORCPT ); Wed, 14 Sep 2022 02:13:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbiINGNN (ORCPT ); Wed, 14 Sep 2022 02:13:13 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73AED71998 for ; Tue, 13 Sep 2022 23:12:58 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id o23so12239996pji.4 for ; Tue, 13 Sep 2022 23:12:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=nOBwV7zD7+DTTpu2RK0hUunUjebAM5dH9U/z6ps0Qmg=; b=YbpxUjlQOGGXqj2Xh2EVFLGC/I8prjgaJZkYUd0xwMKcjkguC4b1JtZNGIAawgMaAc srtLXKEJ0V2nj7DGlfF/I9k36k3nCDoaZb11y+BX0t8809jCz+RsqE8l3xvyDL/uxp58 YsMwUdz3AT4XgJ+B7w3GCmqhvKnR61cZfsSWwBvBCuAi11MkUQ67sD7ETsUs1XxlCafR JKqnMwPVW76MGgoyE4sYizePXDpKYYFSDpCykAC4GXRQyVUuvl12cx9j6nKmVHfo13HD oHpdLKAe/dhihEqkGYt3jhVfl5EKCstqZCEd9MqTYL6VKNqfBmJmlxR1wGk82TeksBK5 8mDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=nOBwV7zD7+DTTpu2RK0hUunUjebAM5dH9U/z6ps0Qmg=; b=1mNUUfWq/7rN0yzXr2SvHhDIhbKPBbDycrQqo8uVi4B9kJpjLOK7iiw+/r/XRnYN1e 72Bp4NYRujdgjkPe1mF109iz0yF9yI62NdD9elj90aJtcD0ppi+qQrBO7rVcFeXWs41D xR/fMIAhpad3kMQVpSAgUYluY7X44NxiSYW7aYenHKeKHcyRm037QxvIHZJM96gSefDd aHB7bbhwZGspXvpFPEnF2ysC5Q0fo4te97QTWtjahSqzZTi0TpC00lnDSx1ZPi2lzqj+ BFCo75YFwd7QyXCn7kTeUm6/fPu8xMbgi7cbzww/88PQTD6BHHjIr0zXCrcp+YcogRbM 1nmw== X-Gm-Message-State: ACgBeo15Lcp5oLkkpiDabwseAE5ZIU2Y+6InLwXI37opy9t/FdsarauH pfO9fAd8NnFz9U4hiSXzV3Ov X-Google-Smtp-Source: AA6agR7WwlEHge+gEuiwlOhrUSQc02S25CmbQjEC8HIHt2FaG+cUdWkvyeQSALaa+F+JpdxOXv3rFw== X-Received: by 2002:a17:903:41c6:b0:178:348e:f760 with SMTP id u6-20020a17090341c600b00178348ef760mr12675069ple.123.1663135977914; Tue, 13 Sep 2022 23:12:57 -0700 (PDT) Received: from workstation ([117.202.184.122]) by smtp.gmail.com with ESMTPSA id h6-20020a170902f54600b0016c4546fbf9sm9676237plf.128.2022.09.13.23.12.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Sep 2022 23:12:57 -0700 (PDT) Date: Wed, 14 Sep 2022 11:42:51 +0530 From: Manivannan Sadhasivam To: Jon Hunter Cc: Vidya Sagar , jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, treding@nvidia.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event logging Message-ID: <20220914061251.GC16459@workstation> References: <20220913101237.4337-1-vidyas@nvidia.com> <20220913165159.GH25849@workstation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Sep 13, 2022 at 06:00:30PM +0100, Jon Hunter wrote: > > On 13/09/2022 17:51, Manivannan Sadhasivam wrote: > > On Tue, Sep 13, 2022 at 03:42:37PM +0530, Vidya Sagar wrote: > > > Some of the platforms (like Tegra194 and Tegra234) have open slots and > > > not having an endpoint connected to the slot is not an error. > > > So, changing the macro from dev_err to dev_info to log the event. > > > > > > > But the link up not happening is an actual error and -ETIMEDOUT is being > > returned. So I don't think the log severity should be changed. > > Yes it is an error in the sense it is a timeout, but reporting an error > because nothing is attached to a PCI slot seems a bit noisy. Please note > that a similar change was made by the following commit and it also seems > appropriate here ... > I got the concern. But the problem here is, we cannot distinguish if the error is due to slot empty or an actual issues with link/phy. Also it should be noted that if the slot is empty, the dwc core anyway waits for the link to be up. IMO this is a boot time overhead that could be avoided if the specific instance could be disabled in platform data like devicetree. > commit 4b16a8227907118e011fb396022da671a52b2272 > Author: Manikanta Maddireddy > Date: Tue Jun 18 23:32:06 2019 +0530 > > PCI: tegra: Change link retry log level to debug > > > BTW, we check for error messages in the dmesg output and this is a new error > seen as of Linux v6.0 and so this was flagged in a test. We can ignore the > error, but in this case it seem more appropriate to make this a info or > debug level print. > On some of the Qcom based platforms, we avoid this situation by disabling the specific PCIe node in devicetree for which we know that there would be no devices connected. This not only avoids the error message in log but also removes the time spent waiting for link to be up. Thanks, Mani > Jon > > -- > nvpublic