From: Ian Cowan <ian@linux.cowan.aero>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Ian Cowan <ian@linux.cowan.aero>
Subject: [PATCH 1/3] PCI: SHPC: remove unused get_mode1_ECC_cap callback declaration
Date: Sat, 12 Nov 2022 09:28:57 -0500 [thread overview]
Message-ID: <20221112142859.319733-2-ian@linux.cowan.aero> (raw)
In-Reply-To: <20221112142859.319733-1-ian@linux.cowan.aero>
The ->get_mode1_ECC_cap callback in the shpchp_hpc_ops struct is never
called so we'll remove it. This removes that callback from the
declaration of the struct in the shpc module.
Signed-off-by: Ian Cowan <ian@linux.cowan.aero>
---
drivers/pci/hotplug/shpchp_hpc.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
index bd7557ca4910..48e4daefc44a 100644
--- a/drivers/pci/hotplug/shpchp_hpc.c
+++ b/drivers/pci/hotplug/shpchp_hpc.c
@@ -489,23 +489,6 @@ static int hpc_get_adapter_speed(struct slot *slot, enum pci_bus_speed *value)
return retval;
}
-static int hpc_get_mode1_ECC_cap(struct slot *slot, u8 *mode)
-{
- int retval = 0;
- struct controller *ctrl = slot->ctrl;
- u16 sec_bus_status = shpc_readw(ctrl, SEC_BUS_CONFIG);
- u8 pi = shpc_readb(ctrl, PROG_INTERFACE);
-
- if (pi == 2) {
- *mode = (sec_bus_status & 0x0100) >> 8;
- } else {
- retval = -1;
- }
-
- ctrl_dbg(ctrl, "Mode 1 ECC cap = %d\n", *mode);
- return retval;
-}
-
static int hpc_query_power_fault(struct slot *slot)
{
struct controller *ctrl = slot->ctrl;
@@ -900,7 +883,6 @@ static const struct hpc_ops shpchp_hpc_ops = {
.get_adapter_status = hpc_get_adapter_status,
.get_adapter_speed = hpc_get_adapter_speed,
- .get_mode1_ECC_cap = hpc_get_mode1_ECC_cap,
.get_prog_int = hpc_get_prog_int,
.query_power_fault = hpc_query_power_fault,
--
2.38.1
next prev parent reply other threads:[~2022-11-12 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 14:28 [PATCH 0/3] PCI: SHPC: removed unused get_mode1_ECC_cap callback Ian Cowan
2022-11-12 14:28 ` Ian Cowan [this message]
2022-11-12 14:28 ` [PATCH 2/3] PCI: SHPC: remove unused get_mode1_ECC_cap callback from definition Ian Cowan
2022-11-12 14:28 ` [PATCH 3/3] PCI: SHPC: update todo Ian Cowan
2022-12-07 14:37 ` [PATCH 0/3] PCI: SHPC: removed unused get_mode1_ECC_cap callback Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221112142859.319733-2-ian@linux.cowan.aero \
--to=ian@linux.cowan.aero \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox