From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Li Ming <ming4.li@intel.com>,
bhelgaas@google.com, Jonathan.Cameron@huawei.com,
ira.weiny@intel.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH V2 1/1] PCI/DOE: Fix maximum data object length miscalculation
Date: Wed, 16 Nov 2022 14:29:02 -0600 [thread overview]
Message-ID: <20221116202902.GA1134656@bhelgaas> (raw)
In-Reply-To: <20221116185610.GA4563@wunner.de>
On Wed, Nov 16, 2022 at 07:56:10PM +0100, Lukas Wunner wrote:
> On Wed, Nov 16, 2022 at 12:02:50PM -0600, Bjorn Helgaas wrote:
> > On Wed, Nov 16, 2022 at 09:56:37AM +0800, Li Ming wrote:
> > > The value of data object length 0x0 indicates 2^18 dwords being
> > > transferred. This patch adjusts the value of data object length for the
> > > above case on both sending side and receiving side.
> > >
> > > Besides, it is unnecessary to check whether length is greater than
> > > SZ_1M while receiving a response data object, because length from LENGTH
> > > field of data object header, max value is 2^18.
> > >
> > > Signed-off-by: Li Ming <ming4.li@intel.com>
> >
> > Applied with Reviewed-by from Jonathan and Lukas, thank you very much
> > to all of you!
> >
> > I touched up the commit log; let me know if I made anything worse:
>
> Jonathan mentioned that a Fixes tag might make sense. If you agree:
>
> Fixes: 9d24322e887b ("PCI/DOE: Add DOE mailbox support functions")
> Cc: stable@vger.kernel.org # v6.0+
Sure, sorry I missed that. Although I don't see it on the list, so
maybe it was a side-band comment. Added in any case.
Bjorn
prev parent reply other threads:[~2022-11-16 20:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 1:56 [PATCH V2 1/1] PCI/DOE: Fix maximum data object length miscalculation Li Ming
2022-11-16 9:37 ` Jonathan Cameron
2022-11-16 9:44 ` Lukas Wunner
2022-11-16 18:02 ` Bjorn Helgaas
2022-11-16 18:07 ` Bjorn Helgaas
2022-11-16 18:56 ` Lukas Wunner
2022-11-16 20:29 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116202902.GA1134656@bhelgaas \
--to=helgaas@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=ira.weiny@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=ming4.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox