From: Lukas Wunner <lukas@wunner.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
Amey Narkhede <ameynarkhede03@gmail.com>,
Ashok Raj <ashok.raj@intel.com>,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Ravi Kishore Koppuravuri <ravi.kishore.koppuravuri@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH] PCI/DPC: Add Software Trigger as reset method
Date: Wed, 30 Nov 2022 08:30:51 +0100 [thread overview]
Message-ID: <20221130073051.GA8198@wunner.de> (raw)
In-Reply-To: <Y4Y1EYZ+1Otx9LaT@kbusch-mbp.dhcp.thefacebook.com>
On Tue, Nov 29, 2022 at 09:36:33AM -0700, Keith Busch wrote:
> On Tue, Nov 29, 2022 at 08:35:55AM +0100, Lukas Wunner wrote:
> > Add DPC Software Trigger as a reset method to be used for silicon
> > validation among other things:
>
> Do you really need a kernel helper to do this? You can test these with
>
> # setpci -s <dsp's b:d.f> ECAP_DPC+6.w=40:40
>
> And since the kernel is a not aware you are synthesizing the DPC event,
> that more naturally tests how the kernel would react to a hardware dpc
> trigger.
I've seen people write a value directly instead of using the "data:mask"
syntax above and that's dangerous because the register is under the
control of the kernel.
By exposing software trigger as a reset method I hope to make its
invocation error-proof and more comfortable.
Thanks,
Lukas
next prev parent reply other threads:[~2022-11-30 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 7:35 [PATCH] PCI/DPC: Add Software Trigger as reset method Lukas Wunner
2022-11-29 13:09 ` Ashok Raj
2022-11-29 15:44 ` Mika Westerberg
2022-11-29 16:27 ` Sathyanarayanan Kuppuswamy
2022-11-30 7:37 ` Lukas Wunner
2022-11-29 16:36 ` Keith Busch
2022-11-30 7:30 ` Lukas Wunner [this message]
2022-12-06 17:11 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130073051.GA8198@wunner.de \
--to=lukas@wunner.de \
--cc=alex.williamson@redhat.com \
--cc=ameynarkhede03@gmail.com \
--cc=ashok.raj@intel.com \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ravi.kishore.koppuravuri@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox