From: Bjorn Helgaas <helgaas@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v3] PCI/portdrv: Allow AER service only for Root Ports & RCECs
Date: Tue, 13 Dec 2022 15:37:47 -0600 [thread overview]
Message-ID: <20221213213747.GA209007@bhelgaas> (raw)
In-Reply-To: <Y5bqU0rc44NtYJXl@infradead.org>
On Mon, Dec 12, 2022 at 12:46:11AM -0800, Christoph Hellwig wrote:
> On Fri, Dec 09, 2022 at 06:29:22PM -0600, Bjorn Helgaas wrote:
> > + if ((pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT ||
> > + pci_pcie_type(dev) == PCI_EXP_TYPE_RC_EC) &&
> > + dev->aer_cap && pci_aer_available() &&
> > (pcie_ports_native || host->native_aer))
>
> Eww, this is really hard to follow. Can you split this out into
> a little helper, that actually documents the decisions based
> on some of the wording you have in the current comit message?
I completely agree. We have basically the same sort of thing for
PCIE_PORT_SERVICE_HP (also added this cycle), PCIE_PORT_SERVICE_AER,
PCIE_PORT_SERVICE_PME, and PCIE_PORT_SERVICE_DPC. I'd really like to
figure out a way to centralize the check for pcie_ports_native,
host->native_aer, etc., because they clutter a lot of places.
I didn't have time to work on that this cycle, but maybe next time.
Bjorn
next prev parent reply other threads:[~2022-12-13 21:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 0:29 [PATCH v3] PCI/portdrv: Allow AER service only for Root Ports & RCECs Bjorn Helgaas
2022-12-10 0:53 ` Sathyanarayanan Kuppuswamy
2022-12-12 6:21 ` Mika Westerberg
2022-12-12 8:46 ` Christoph Hellwig
2022-12-13 21:37 ` Bjorn Helgaas [this message]
2022-12-14 7:00 ` Gupta, Anshuman
2023-12-14 6:37 ` Matthew W Carlis
2023-12-14 20:28 ` Bjorn Helgaas
2023-12-14 21:45 ` Matthew W Carlis
[not found] ` <CAPYCUs41ZfLUCLAYqfjyzXoDELkt1+6nMz6U68FAOx9TXoCbYQ@mail.gmail.com>
2023-12-14 21:47 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213213747.GA209007@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox