From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: adjust to recent removal of PCI_MSI_IRQ_DOMAIN
Date: Fri, 16 Dec 2022 18:53:04 +0300 [thread overview]
Message-ID: <20221216155304.uckgqbcgotqj6bha@mobilestation> (raw)
In-Reply-To: <20221215103452.23131-1-lukas.bulwahn@gmail.com>
On Thu, Dec 15, 2022 at 11:34:52AM +0100, Lukas Bulwahn wrote:
> Commit a474d3fbe287 ("PCI/MSI: Get rid of PCI_MSI_IRQ_DOMAIN") removes the
> config PCI_MSI_IRQ_DOMAIN and makes all previous references to that config
> then refer to PCI_MSI instead.
>
> Commit ba6ed462dcf4 ("PCI: dwc: Add Baikal-T1 PCIe controller support")
> adds the config PCIE_BT1, which following the previous default pattern
> depends on the config PCI_MSI_IRQ_DOMAIN.
>
> As these two commits were submitted roughly at the same time, the
> refactoring did not take of this occurrence and the addition did not yet
> notice the refactoring.
>
> Take care of the PCI_MSI config refactoring on this latest addition.
Indeed. I just didn't know about the refactoring. Thanks for submitting
a fixup patch.
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
-Serge(y)
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/pci/controller/dwc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index a0d2713f0e88..99ec91e2a5cf 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -225,7 +225,7 @@ config PCIE_ARTPEC6_EP
> config PCIE_BT1
> tristate "Baikal-T1 PCIe controller"
> depends on MIPS_BAIKAL_T1 || COMPILE_TEST
> - depends on PCI_MSI_IRQ_DOMAIN
> + depends on PCI_MSI
> select PCIE_DW_HOST
> help
> Enables support for the PCIe controller in the Baikal-T1 SoC to work
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2022-12-16 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 10:34 [PATCH] PCI: dwc: adjust to recent removal of PCI_MSI_IRQ_DOMAIN Lukas Bulwahn
2022-12-16 15:53 ` Serge Semin [this message]
2022-12-30 13:23 ` Lorenzo Pieralisi
2023-01-03 20:06 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221216155304.uckgqbcgotqj6bha@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox