From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B11DC4167B for ; Fri, 23 Dec 2022 15:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236461AbiLWPCm (ORCPT ); Fri, 23 Dec 2022 10:02:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236456AbiLWPCl (ORCPT ); Fri, 23 Dec 2022 10:02:41 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D370626115 for ; Fri, 23 Dec 2022 07:02:40 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id m4so5196656pls.4 for ; Fri, 23 Dec 2022 07:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=hym9I/8Zx2heqtzvbjDG8T0F+0F1WrxSB82+3fgXrCs=; b=RkCDOqxRJ5Xj+NtiaIuQ7fE0ZtalDZpwA/P+90rf5TxBXdVQ443U5LuxQLa9Tm/iJR D9+DuWqGVaV85SXh7UOEIQqZgr2KHx5o/sV6sXxpfT1o0iGRqjGE42Ojx2a6zsOF9nAX ZCWcdCbbLudnqN/jTnwkQFRzR4UiohqVkiiBkoesaQ/2+N+tZYqORIU239tmSqGQzZlG I5zWinTF/XhOZOTYXqVRVxrNGNR1ONpTXfaUWaSSKoIsAG/U7WQCfm1F0saKWyYo1ytZ 1Vg9kpU1Jun115p3Nk0259QS97eHycTJta0AofuqIzWsclScrcV6zBjVABn8EeTmNImK vqhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hym9I/8Zx2heqtzvbjDG8T0F+0F1WrxSB82+3fgXrCs=; b=Bh7QcHYCxThcfLgGPxpV/4KSiW+twl7m0/Ixh9k4o22AAsY2Olp+Nskdlho+lNdA1H GI+9Sb2r+j5URpjQ10pBm8McQf0sOZpK+CoC2xpvH8YJIGuhIU4YHgtqL5gfCTir0Q2d DAnMru0iw7EfoW7DFd4p19gFKfprrz2fj13EaHjzmoK7H5fIGwAabSoIeJQ6h1P8pppg Vkf+bT+upzg2xkoczX1q4hWscKmYi7KBF0EYkXFNTzOWzfINTkMBmVXv0atgClPtOipk VzzCP3Gd5sFub9jUsABydRFVNge1Y4nmnLT8q9gMGGxbRIlSzCrT4WrYQ07brA+zNpbm UMhg== X-Gm-Message-State: AFqh2kp7PkIfNoKqVWrBEB8YQ1p+Ip0md6E/hMISibxvLYvhu/RAAfDc YY+S1ut1tUHrSmtDZ+H6bblr X-Google-Smtp-Source: AMrXdXtsYyuhBmpwbDlQIl+Ry+zm4L2NR4g7iB8qu6wucOubA3roxo2rzNv7BgX/Hpk+rfDsHjmOOA== X-Received: by 2002:a17:90a:ce8c:b0:223:f6c2:f21a with SMTP id g12-20020a17090ace8c00b00223f6c2f21amr10749315pju.35.1671807760314; Fri, 23 Dec 2022 07:02:40 -0800 (PST) Received: from thinkpad ([27.111.75.82]) by smtp.gmail.com with ESMTPSA id 3-20020a17090a034300b002191e769546sm2373891pjf.4.2022.12.23.07.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Dec 2022 07:02:39 -0800 (PST) Date: Fri, 23 Dec 2022 20:32:11 +0530 From: Manivannan Sadhasivam To: Shuah Khan Cc: Aman Gupta , shradha.t@samsung.com, pankaj.dubey@samsung.com, kishon@ti.com, lpieralisi@kernel.org, kw@linux.com, shuah@kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, Padmanabhan Rajanbabu Subject: Re: [PATCH] selftests: pci: pci-selftest: add support for PCI endpoint driver test Message-ID: <20221223150211.GC4587@thinkpad> References: <20221007053934.5188-1-aman1.gupta@samsung.com> <641d1e50-a9d0-dc15-be76-07b8ace25dae@linuxfoundation.org> <20221222174532.GA59500@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Dec 22, 2022 at 10:49:48AM -0700, Shuah Khan wrote: > On 12/22/22 10:45, Manivannan Sadhasivam wrote: > > On Thu, Dec 22, 2022 at 09:58:30AM -0700, Shuah Khan wrote: > > > On 10/6/22 23:39, Aman Gupta wrote: > > > > This patch enables the support to perform selftest on PCIe endpoint > > > > driver present in the system. The following tests are currently > > > > performed by the selftest utility > > > > > > > > 1. BAR Tests (BAR0 to BAR5) > > > > 2. MSI Interrupt Tests (MSI1 to MSI32) > > > > 3. Read Tests (For 1, 1024, 1025, 1024000, 1024001 Bytes) > > > > 4. Write Tests (For 1, 1024, 1025, 1024000, 1024001 Bytes) > > > > 5. Copy Tests (For 1, 1024, 1025, 1024000, 1024001 Bytes) > > > > > > > > Signed-off-by: Aman Gupta > > > > Signed-off-by: Padmanabhan Rajanbabu > > > > > > Adding Bjorn Helgaas to the thread. > > > > > > Adding pcit test under selftests is good. There is another pcitest > > > under tools/pci. I would like to see if the existing code in > > > tools/pci/pcitest.c can be leveraged. > > > > > > As part of this test work, also look into removing tools/pci so > > > we don't have to maintain duplicate code in two places. > > > > > > > It has been agreed in a thread with Greg [1] to {re}move the tests under > > tools/pci and utilize the kselftest. > > > > Inline with what I am suggesting. However, I don't see either move or > delete of tools/pci in the patch? > > The first patch could start with git mv of the existing files and then > make changes to preserver the history. > Right. This patch was posted independently of the series [1] that I submitted to fix the return values of IOCTL calls used in drivers/misc/pci_endpoint_test.c driver. Then in that series, it was decided to move the existing test to kselftest. So, I suggested Aman Gupta [2] to integrate my latest patches, add the kselftest patch on top, then remove the existing test under tools/pci. The kselftest patch can also move the driver first and then make the change as you suggested. Either way it is fine by me. Thanks, Mani [1] https://lore.kernel.org/lkml/20220824123010.51763-1-manivannan.sadhasivam@linaro.org/ [2] https://lore.kernel.org/linux-pci/20221221072423.GC2922@thinkpad/ > > > > [1] https://lore.kernel.org/lkml/Y2FTWLw0tKuZ9Cdl@kroah.com/ > > > > thanks, > -- Shuah > -- மணிவண்ணன் சதாசிவம்