From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E154C46467 for ; Tue, 3 Jan 2023 14:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237436AbjACOVM (ORCPT ); Tue, 3 Jan 2023 09:21:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237235AbjACOVL (ORCPT ); Tue, 3 Jan 2023 09:21:11 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C097103E; Tue, 3 Jan 2023 06:21:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0C657B80E4A; Tue, 3 Jan 2023 14:21:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81797C433EF; Tue, 3 Jan 2023 14:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672755666; bh=QUDZzmWFzPSdSBUtQKpi4loUsOtqH8FrkQ91X2uvAOM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=tOyX8B6chAWJsL9m+at0UkVDXaPlwFNAtVfIe8xwlD0bq3KlKicnSRn1koeKwptfj 5LifzE2ym6crzcv1h0TPR8Un2wV/Ljwoksm2BGcJCqf5jr3UlEVjlddeHqTDgX0VXI gtjbBy0I07sMlrq4g5rvfddQCscYc1Y3mR3cmLJgRW3D9pSiPt0sixwUiCM2aY3lqo r5US4fWJZsREhhKWkSBoea8hmktyMQqwg7vtLvW+MrmoFxmOmFOojJj0tEZW/x40ue 4zSZrUOwVq6Sxk/Ukaq1hT2Go4Ae0McsAy4UGiFt00ux217yPW23Sj7C58NjjNaKUh 8NLmzxwLiPiMg== Date: Tue, 3 Jan 2023 08:21:04 -0600 From: Bjorn Helgaas To: Leon Romanovsky Cc: Paul Menzel , Rajat Khandelwal , anthony.l.nguyen@intel.com, netdev@vger.kernel.org, rajat.khandelwal@intel.com, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, edumazet@google.com, intel-wired-lan@lists.osuosl.org, linux-pci@vger.kernel.org, Bjorn Helgaas , kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net Subject: Re: [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout errors in I225_LMVP Message-ID: <20230103142104.GA996978@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jan 03, 2023 at 02:00:04PM +0200, Leon Romanovsky wrote: > On Tue, Jan 03, 2023 at 05:54:02AM -0600, Bjorn Helgaas wrote: > > On Tue, Jan 03, 2023 at 11:54:24AM +0200, Leon Romanovsky wrote: > > > On Sun, Jan 01, 2023 at 11:34:21AM +0100, Paul Menzel wrote: > > > > Am 01.01.23 um 09:32 schrieb Leon Romanovsky: > > > > > On Thu, Dec 29, 2022 at 05:56:40PM +0530, Rajat Khandelwal wrote: > > > > > > The CPU logs get flooded with replay rollover/timeout AER errors in > > > > > > the system with i225_lmvp connected, usually inside thunderbolt devices. > > > > > > > > > > > > One of the prominent TBT4 docks we use is HP G4 Hook2, which incorporates > > > > > > an Intel Foxville chipset, which uses the igc driver. > > > > > > On connecting ethernet, CPU logs get inundated with these errors. The point > > > > > > is we shouldn't be spamming the logs with such correctible errors as it > > > > > > confuses other kernel developers less familiar with PCI errors, support > > > > > > staff, and users who happen to look at the logs. > > > > > > > > --- a/drivers/net/ethernet/intel/igc/igc_main.c > > > > > > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > > > > > > > > +static void igc_mask_aer_replay_correctible(struct igc_adapter *adapter) > > > > > > > Shouldn't this igc_mask_aer_replay_correctible function be implemented > > > > > in drivers/pci/quirks.c and not in igc_probe()? > > > > > > > > Probably. Though I think, the PCI quirk file, is getting too big. > > > > > > As long as that file is right location, we should use it. > > > One can refactor quirk file later. > > > > If a quirk like this is only needed when the driver is loaded, > > This is always the case with PCI devices managed through kernel, isn't it? > Users don't care/aware about "broken" devices unless they start to use them. Indeed, that's usually the case. There's a lot of stuff in quirks.c that could probably be in drivers instead. Bjorn