From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Lukas Wunner <lukas@wunner.de>,
Chris Chiu <chris.chiu@canonical.com>,
Alexander Motin <mav@ixsystems.com>,
Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-pci@vger.kernel.org
Subject: [PATCH v4 0/2] PCI: distribute resources for root buses
Date: Wed, 4 Jan 2023 11:16:33 +0200 [thread overview]
Message-ID: <20230104091635.63331-1-mika.westerberg@linux.intel.com> (raw)
Hi all,
This is fourth iteration of the patch series trying to solve the problem
reported by Chris Chiu [1]. In summary the current resource distribution
code does not cover the initial device enumeration so if we find
unconfigured bridges they get the bare minimum.
In addition to that it turned out the current resource distribution code
does not take into account possible multifunction devices and/or other
devices on the bus. The patch 1/2 tries to make it more generic. I've
tested it on QEMU following the topology Jonathan is using and also in a
a couple of systems with Thunderbolt controller and complex topologies
to make sure it still keeps working.
The previous versions of the series can be found:
v3: https://lore.kernel.org/linux-pci/20221130112221.66612-1-mika.westerberg@linux.intel.com/
v2: https://lore.kernel.org/linux-pci/20221114115953.40236-1-mika.westerberg@linux.intel.com/
v1: https://lore.kernel.org/linux-pci/20221103103254.30497-1-mika.westerberg@linux.intel.com/
Changes from v3:
* Make it more generic and not depend on how many bridges there are
on the bus.
Changes from v2:
* Make both patches to work with PCI devices too (do not expect that
the bridge is always first device on the bus).
* Allow distribution with bridges that do not have all resource
windows programmed (therefore the patch 2/2 is not revert anymore)
* I did not add the tags from Rafael and Jonathan because the code is
not exactly the same anymore so was not sure if they still apply.
Changes from v1:
* Re-worded the commit message to hopefully explain the problem better
* Added Link: to the bug report
* Update the comment according to Bjorn's suggestion
* Dropped the ->multifunction check
* Use %#llx in log format.
[1] https://bugzilla.kernel.org/show_bug.cgi?id=216000
Mika Westerberg (2):
PCI: Take other bus devices into account when distributing resources
PCI: Distribute available resources for root buses too
drivers/pci/setup-bus.c | 262 ++++++++++++++++++++++++++++------------
1 file changed, 185 insertions(+), 77 deletions(-)
--
2.35.1
next reply other threads:[~2023-01-04 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:16 Mika Westerberg [this message]
2023-01-04 9:16 ` [PATCH v4 1/2] PCI: Take other bus devices into account when distributing resources Mika Westerberg
2023-01-04 22:48 ` Bjorn Helgaas
2023-01-05 9:12 ` Mika Westerberg
2023-01-05 13:43 ` Mika Westerberg
2023-01-05 17:04 ` Bjorn Helgaas
2023-01-09 11:11 ` Mika Westerberg
2023-01-09 18:27 ` Alexander Motin
2023-01-10 10:07 ` Mika Westerberg
2023-01-09 19:33 ` Alexander Motin
2023-01-10 9:54 ` Mika Westerberg
2023-01-04 9:16 ` [PATCH v4 2/2] PCI: Distribute available resources for root buses too Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104091635.63331-1-mika.westerberg@linux.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=chris.chiu@canonical.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mav@ixsystems.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox