From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80080C00A5A for ; Wed, 18 Jan 2023 00:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229458AbjARAAL (ORCPT ); Tue, 17 Jan 2023 19:00:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjAQX7c (ORCPT ); Tue, 17 Jan 2023 18:59:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E02C1893CC; Tue, 17 Jan 2023 15:14:20 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 53FABB81A62; Tue, 17 Jan 2023 23:14:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7012C433D2; Tue, 17 Jan 2023 23:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673997258; bh=UyCduLUKDHMuOlRKdVS07Ic8VuPeGTimn3Gjp7iIcuQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=prWGvCBKzqqnRYOonvhjMq6+HuXZbQ2bfu69j6jTopGc49O7slkoNWl99+J3sTOOv fqpj0RKNXt9Fm/40r3Th2EjwutW6hokYmVsQpnNMBDaBIIO+5qQ24qhMVkFY/cYezZ 3w9sh5VsObHXNzDod1HUKS5obzITXfKfbY6JI4JgsntOOULF/alKpv0szDoiOT7sbT HJ1Qkj/Yu8/o/QR/q4DeRFj85RJPR9GnJVdP8MK3UwWtEvPTmsWK+Tz5XTNpGCn2b5 BEPGKuw6GqJ3DgkhLhboFjXXfl1s0ZUV7fuPncg9oQJDREU3lRngcQdIzt/qmLRCEU k0Oj0YW3kfYGw== Date: Tue, 17 Jan 2023 17:14:16 -0600 From: Bjorn Helgaas To: Kai-Heng Feng Cc: bhelgaas@google.com, Mario Limonciello , Mika Westerberg , Keith Busch , Kuppuswamy Sathyanarayanan , Pali =?iso-8859-1?Q?Roh=E1r?= , Stefan Roese , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI/portdrv: Avoid enabling AER on Thunderbolt devices Message-ID: <20230117231416.GA158056@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221226153048.1208359-1-kai.heng.feng@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Dec 26, 2022 at 11:30:31PM +0800, Kai-Heng Feng wrote: > We are seeing igc ethernet device on Thunderbolt dock stops working > after S3 resume because of AER error, or even make S3 resume freeze: > pcieport 0000:00:1d.0: AER: Multiple Corrected error received: 0000:00:1d.0 > pcieport 0000:00:1d.0: PCIe Bus Error: severity=Corrected, type=Transaction Layer, (Receiver ID) > pcieport 0000:00:1d.0: device [8086:7ab0] error status/mask=00008000/00002000 > pcieport 0000:00:1d.0: [15] HeaderOF > pcieport 0000:00:1d.0: AER: Multiple Uncorrected (Non-Fatal) error received: 0000:00:1d.0 > pcieport 0000:00:1d.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) > pcieport 0000:00:1d.0: device [8086:7ab0] error status/mask=00100000/00004000 > pcieport 0000:00:1d.0: [20] UnsupReq (First) > pcieport 0000:00:1d.0: AER: TLP Header: 34000000 0a000052 00000000 00000000 > pcieport 0000:00:1d.0: AER: Error of this Agent is reported first > pcieport 0000:04:01.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) > pcieport 0000:04:01.0: device [8086:1136] error status/mask=00300000/00000000 > pcieport 0000:04:01.0: [20] UnsupReq (First) > pcieport 0000:04:01.0: [21] ACSViol > pcieport 0000:04:01.0: AER: TLP Header: 34000000 04000052 00000000 00000000 > thunderbolt 0000:05:00.0: AER: can't recover (no error_detected callback) Is this a regression? E.g., is this something that started after f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native") or something similar? Bjorn