From: Bjorn Helgaas <helgaas@kernel.org>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: "Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Vinod Koul" <vkoul@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Cai Huoqing" <cai.huoqing@linux.dev>,
"Robin Murphy" <robin.murphy@arm.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Alexey Malahov" <Alexey.Malahov@baikalelectronics.ru>,
"Pavel Parkhomenko" <Pavel.Parkhomenko@baikalelectronics.ru>,
"Krzysztof Wilczyński" <kw@linux.com>,
caihuoqing <caihuoqing@baidu.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 24/27] dmaengine: dw-edma: Relax driver config settings
Date: Wed, 25 Jan 2023 17:23:57 -0600 [thread overview]
Message-ID: <20230125232357.GA1176625@bhelgaas> (raw)
In-Reply-To: <20230125144019.sn7kliw3qlwgtwzs@mobilestation>
On Wed, Jan 25, 2023 at 05:40:19PM +0300, Serge Semin wrote:
> On Tue, Jan 24, 2023 at 05:47:44PM -0600, Bjorn Helgaas wrote:
> > In the commit log, I think "forcibly selecting the DW eDMA driver from
> > the DW PCIe RP/EP kconfig" actually refers to just the "DW eDMA PCIe"
> > driver" not the "DW PCIe RP/EP driver," right?
>
> Right.
Good. I think it's worth updating the commit log to clear this up
because there are several things with very similar names, so it's
confusing enough already ;)
> > The undefined reference to dw_edma_probe() doesn't actually happen
> > unless we merge 27/27 without *this* patch, right?
>
> Right.
Thanks, I got unreasonably focused on the "fix 'undefined reference'
error" comment, wondering if we needed to identify a Fixes: commit, so
this clears that up, too.
> > I would use "depends on
> > DW_EDMA" instead of adding if/endif around DW_EDMA_PCIE.
>
> Could you explain why is the "depends on" operator more preferable
> than if/endif? In this case since we have a single core kconfig from
> which all the eDMA LLDD config(s) (except PCIE_DW for the reason
> previously described) will surely depend on, using if/endif would
> cause the possible new eDMA-capable LLDD(s) adding their kconfig
> entries within the if-endif clause without need to copy the same
> "depends on DW_EDMA" pattern over and over. That seems to look a bit
> more maintainable than the alternative you suggest. Do you think
> otherwise?
Only that "depends on" is much more common and I always try to avoid
unusual constructs. But I wasn't looking into the future and
imagining several LLDDs with similar uses of "depends on DW_EDMA".
Thanks for that perspective; with it, I think it's OK either way.
> > What do you think?
>
> What you described was the second option I had in mind for the update
> to look like, but after all I decided to take a shorter path and
> combine the modifications into a single patch. If you think that
> splitting it up would make the update looking simpler then I'll do as
> you suggest. But in that case Lorenzo will need to re-merge the
> updated patchset v10.
It's a pretty trivial update, so I just did it myself. The result is
at https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/ctrl/dwc&id=ecadcaed4ef7
I split this patch and tweaked some commit messages for consistency
(including the "DW eDMA PCIe driver" change above). "git diff -b"
with Lorenzo's current branch (95624672bb3e ("PCI: dwc: Add DW eDMA
engine support")) is empty except for a minor comment change.
Bjorn
next prev parent reply other threads:[~2023-01-25 23:24 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 17:13 [PATCH v9 00/27] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2023-01-13 17:13 ` [PATCH v9 01/27] dmaengine: Fix dma_slave_config.dst_addr description Serge Semin
2023-01-13 17:13 ` [PATCH v9 02/27] dmaengine: dw-edma: Release requested IRQs on failure Serge Semin
2023-01-13 17:13 ` [PATCH v9 03/27] dmaengine: dw-edma: Convert ll/dt phys-address to PCIe bus/DMA address Serge Semin
2023-01-13 17:13 ` [PATCH v9 04/27] dmaengine: dw-edma: Fix missing src/dst address of the interleaved xfers Serge Semin
2023-01-13 17:13 ` [PATCH v9 05/27] dmaengine: dw-edma: Don't permit non-inc " Serge Semin
2023-01-13 17:13 ` [PATCH v9 06/27] dmaengine: dw-edma: Fix invalid interleaved xfers semantics Serge Semin
2023-01-13 17:13 ` [PATCH v9 07/27] dmaengine: dw-edma: Add CPU to PCIe bus address translation Serge Semin
2023-01-13 17:13 ` [PATCH v9 08/27] dmaengine: dw-edma: Add PCIe bus address getter to the remote EP glue-driver Serge Semin
2023-01-20 23:29 ` Bjorn Helgaas
2023-01-21 20:37 ` Serge Semin
2023-01-13 17:13 ` [PATCH v9 09/27] dmaengine: dw-edma: Drop chancnt initialization Serge Semin
2023-01-20 23:54 ` Bjorn Helgaas
2023-01-21 21:10 ` Serge Semin
2023-01-13 17:13 ` [PATCH v9 10/27] dmaengine: dw-edma: Fix DebugFS reg entry type Serge Semin
2023-01-13 17:13 ` [PATCH v9 11/27] dmaengine: dw-edma: Stop checking debugfs_create_*() return value Serge Semin
2023-01-13 17:13 ` [PATCH v9 12/27] dmaengine: dw-edma: Add dw_edma prefix to the DebugFS nodes descriptor Serge Semin
2023-01-13 17:13 ` [PATCH v9 13/27] dmaengine: dw-edma: Convert DebugFS descs to being kz-allocated Serge Semin
2023-01-13 17:13 ` [PATCH v9 14/27] dmaengine: dw-edma: Rename DebugFS dentry variables to 'dent' Serge Semin
2023-01-13 17:13 ` [PATCH v9 15/27] dmaengine: dw-edma: Simplify the DebugFS context CSRs init procedure Serge Semin
2023-01-13 17:13 ` [PATCH v9 16/27] dmaengine: dw-edma: Move eDMA data pointer to DebugFS node descriptor Serge Semin
2023-01-13 17:13 ` [PATCH v9 17/27] dmaengine: dw-edma: Join Write/Read channels into a single device Serge Semin
2023-01-13 17:14 ` [PATCH v9 18/27] dmaengine: dw-edma: Use DMA-engine device DebugFS subdirectory Serge Semin
2023-01-13 17:14 ` [PATCH v9 19/27] dmaengine: dw-edma: Use non-atomic io-64 methods Serge Semin
2023-01-21 0:54 ` Bjorn Helgaas
2023-01-21 23:03 ` Serge Semin
2023-01-23 16:37 ` Bjorn Helgaas
2023-01-24 13:44 ` Serge Semin
2023-01-13 17:14 ` [PATCH v9 20/27] dmaengine: dw-edma: Drop DT-region allocation Serge Semin
2023-01-13 17:14 ` [PATCH v9 21/27] dmaengine: dw-edma: Replace chip ID number with device name Serge Semin
2023-01-13 17:14 ` [PATCH v9 22/27] dmaengine: dw-edma: Skip cleanup procedure if no private data found Serge Semin
2023-01-13 17:14 ` [PATCH v9 23/27] dmaengine: dw-edma: Add mem-mapped LL-entries support Serge Semin
2023-02-21 23:00 ` Bjorn Helgaas
2023-02-22 16:16 ` Vinod Koul
2023-01-13 17:14 ` [PATCH v9 24/27] dmaengine: dw-edma: Relax driver config settings Serge Semin
2023-01-20 22:50 ` Bjorn Helgaas
2023-01-22 0:11 ` Serge Semin
2023-01-23 16:43 ` Bjorn Helgaas
2023-01-24 14:49 ` Serge Semin
2023-01-24 23:47 ` Bjorn Helgaas
2023-01-25 14:40 ` Serge Semin
2023-01-25 23:23 ` Bjorn Helgaas [this message]
2023-01-26 16:37 ` Serge Semin
2023-01-26 18:19 ` Bjorn Helgaas
2023-01-26 21:16 ` Serge Semin
2023-01-13 17:14 ` [PATCH v9 25/27] PCI: dwc: Set coherent DMA-mask on MSI-address allocation Serge Semin
2023-01-20 21:59 ` Bjorn Helgaas
2023-01-22 0:34 ` Serge Semin
2023-01-13 17:14 ` [PATCH v9 26/27] PCI: bt1: Set 64-bit DMA-mask Serge Semin
2023-01-13 17:14 ` [PATCH v9 27/27] PCI: dwc: Add DW eDMA engine support Serge Semin
2023-01-13 18:34 ` [PATCH v9 00/27] dmaengine: dw-edma: Add RP/EP local DMA controllers support Serge Semin
2023-01-16 9:52 ` Lorenzo Pieralisi
2023-01-16 11:29 ` Serge Semin
2023-01-20 15:17 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125232357.GA1176625@bhelgaas \
--to=helgaas@kernel.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Frank.Li@nxp.com \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=caihuoqing@baidu.com \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).