Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: linux-pci@vger.kernel.org, Thomas Witt <kernel@witt.link>,
	Vidya Sagar <vidyas@nvidia.com>,
	linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH 2/2] Revert "PCI/ASPM: Refactor L1 PM Substates Control Register programming"
Date: Sat, 4 Feb 2023 14:48:00 -0600	[thread overview]
Message-ID: <20230204204800.GA2107870@bhelgaas> (raw)
In-Reply-To: <20230204174525.GA917@wunner.de>

On Sat, Feb 04, 2023 at 06:45:25PM +0100, Lukas Wunner wrote:
> On Fri, Feb 03, 2023 at 04:48:20PM -0600, Bjorn Helgaas wrote:
> > Thomas Witt reported that 5e85eba6f50d ("PCI/ASPM: Refactor L1 PM Substates
> > Control Register programming") broke suspend/resume on a Tuxedo
> > Infinitybook S 14 v5, which seems to use a Clevo L140CU Mainboard.
> > 
> > The main symptom is:
> > 
> >   iwlwifi 0000:02:00.0: Unable to change power state from D3hot to D0, device inaccessible
> >   nvme 0000:03:00.0: Unable to change power state from D3hot to D0, device inaccessible
> > 
> > and the machine is only partially usable after resume.  It can't run dmesg
> > and can't do a clean reboot.  This happens on every suspend/resume cycle.
> > 
> > Revert 5e85eba6f50d until we can figure out the root cause.
> > 
> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=216877
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216877
> Fixes: 5e85eba6f50d ("PCI/ASPM: Refactor L1 PM Substates Control Register programming")
> Cc: stable@vger.kernel.org # v6.1+

It's a pattern ;)  Thanks again!

      reply	other threads:[~2023-02-04 20:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 22:48 [PATCH 0/2] Revert ASPM L1 Substates updates Bjorn Helgaas
2023-02-03 22:48 ` [PATCH 1/2] Revert "PCI/ASPM: Save L1 PM Substates Capability for suspend/resume" Bjorn Helgaas
2023-02-03 22:48 ` [PATCH 2/2] Revert "PCI/ASPM: Refactor L1 PM Substates Control Register programming" Bjorn Helgaas
2023-02-04 17:45   ` Lukas Wunner
2023-02-04 20:48     ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230204204800.GA2107870@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=kernel@witt.link \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox