From: Bjorn Helgaas <helgaas@kernel.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: bhelgaas@google.com,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Keith Busch" <kbusch@kernel.org>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Pali Rohár" <pali@kernel.org>, "Stefan Roese" <sr@denx.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI/portdrv: Avoid enabling AER on Thunderbolt devices
Date: Mon, 13 Feb 2023 18:10:05 -0600 [thread overview]
Message-ID: <20230214001005.GA2951618@bhelgaas> (raw)
In-Reply-To: <CAAd53p78cLYFCuE1jftygeZttGPvzegv-JDsGJnZxPxMiZUSwA@mail.gmail.com>
On Wed, Feb 08, 2023 at 09:33:18PM +0800, Kai-Heng Feng wrote:
> Hi Bjorn,
>
> Sorry for the belated response.
>
> On Wed, Jan 18, 2023 at 7:14 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > On Mon, Dec 26, 2022 at 11:30:31PM +0800, Kai-Heng Feng wrote:
> > > We are seeing igc ethernet device on Thunderbolt dock stops working
> > > after S3 resume because of AER error, or even make S3 resume freeze:
> > > pcieport 0000:00:1d.0: AER: Multiple Corrected error received: 0000:00:1d.0
> > > pcieport 0000:00:1d.0: PCIe Bus Error: severity=Corrected, type=Transaction Layer, (Receiver ID)
> > > pcieport 0000:00:1d.0: device [8086:7ab0] error status/mask=00008000/00002000
> > > pcieport 0000:00:1d.0: [15] HeaderOF
> > > pcieport 0000:00:1d.0: AER: Multiple Uncorrected (Non-Fatal) error received: 0000:00:1d.0
> > > pcieport 0000:00:1d.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID)
> > > pcieport 0000:00:1d.0: device [8086:7ab0] error status/mask=00100000/00004000
> > > pcieport 0000:00:1d.0: [20] UnsupReq (First)
> > > pcieport 0000:00:1d.0: AER: TLP Header: 34000000 0a000052 00000000 00000000
> > > pcieport 0000:00:1d.0: AER: Error of this Agent is reported first
> > > pcieport 0000:04:01.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID)
> > > pcieport 0000:04:01.0: device [8086:1136] error status/mask=00300000/00000000
> > > pcieport 0000:04:01.0: [20] UnsupReq (First)
> > > pcieport 0000:04:01.0: [21] ACSViol
> > > pcieport 0000:04:01.0: AER: TLP Header: 34000000 04000052 00000000 00000000
> > > thunderbolt 0000:05:00.0: AER: can't recover (no error_detected callback)
> >
> > Is this a regression? E.g., is this something that started after
> > f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native") or
> > something similar?
>
> Reverting the commit doesn't help. Because 0000:00:1d.0 is already
> native so AER is already enabled.
OK. Unless I missed it, we don't really have a root cause or a good
reason to disable AER on removable devices. I don't want to disable
AER indiscriminately. The fact that we see errors doesn't seem like a
good enough reason.
Bjorn
next prev parent reply other threads:[~2023-02-14 0:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 15:30 [PATCH] PCI/portdrv: Avoid enabling AER on Thunderbolt devices Kai-Heng Feng
2022-12-26 15:46 ` Pali Rohár
2022-12-29 3:45 ` Kai-Heng Feng
2022-12-29 12:02 ` Pali Rohár
2022-12-29 16:51 ` Bjorn Helgaas
2022-12-26 22:50 ` Bjorn Helgaas
2022-12-29 4:26 ` Kai-Heng Feng
2023-01-17 23:14 ` Bjorn Helgaas
2023-02-08 13:33 ` Kai-Heng Feng
2023-02-14 0:10 ` Bjorn Helgaas [this message]
2023-05-16 14:14 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214001005.GA2951618@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kai.heng.feng@canonical.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pali@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox