From: Bjorn Helgaas <helgaas@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"kw@linux.com" <kw@linux.com>,
"mani@kernel.org" <mani@kernel.org>,
"kishon@kernel.org" <kishon@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Frank.Li@nxp.com" <Frank.Li@nxp.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH RESEND] PCI: endpoint: functions/pci-epf-test: Fix dma_chan direction
Date: Wed, 22 Feb 2023 13:53:06 -0600 [thread overview]
Message-ID: <20230222195306.GA3792242@bhelgaas> (raw)
In-Reply-To: <TYBPR01MB5341044E7B5A38A65235652CD8AA9@TYBPR01MB5341.jpnprd01.prod.outlook.com>
On Wed, Feb 22, 2023 at 12:49:14AM +0000, Yoshihiro Shimoda wrote:
> > From: Bjorn Helgaas, Sent: Wednesday, February 22, 2023 5:08 AM
> > On Tue, Feb 21, 2023 at 07:17:06PM +0900, Yoshihiro Shimoda wrote:
> > > In the pci_epf_test_init_dma_chan(), epf_test->dma_chan_rx
> > > is assigned from dma_request_channel() with DMA_DEV_TO_MEM as
> > > filter.dma_mask. However, in the pci_epf_test_data_transfer(),
> > > if the dir is DMA_DEV_TO_MEM, it should use epf->dma_chan_rx,
> > > but it used epf_test->dma_chan_tx. So, fix it. Otherwise,
> > > results of pcitest with enabled DMA will be NG on eDMA
> > > environment.
> >
> > "NG"?
>
> I'm sorry, I completely mistook this.
> This should be "NOT OKAY", not "NG".
That should match something printed by pcitest, which would be a good
thing. Thanks for expanding it for non-pcitest experts like me!
Bjorn
prev parent reply other threads:[~2023-02-22 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 10:17 [PATCH RESEND] PCI: endpoint: functions/pci-epf-test: Fix dma_chan direction Yoshihiro Shimoda
2023-02-21 20:08 ` Bjorn Helgaas
2023-02-22 0:49 ` Yoshihiro Shimoda
2023-02-22 19:53 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222195306.GA3792242@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).