From: Sajid Dalvi <sdalvi@google.com>
To: "Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>
Cc: Sajid Dalvi <sdalvi@google.com>,
kernel-team@android.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] PCI: dwc: Wait for link up only if link is started
Date: Mon, 27 Feb 2023 14:13:40 -0600 [thread overview]
Message-ID: <20230227201340.2087605-1-sdalvi@google.com> (raw)
In dw_pcie_host_init() regardless of whether the link has been started
or not, the code waits for the link to come up. Even in cases where
start_link() is not defined the code ends up spinning in a loop for 1
second. Since in some systems dw_pcie_host_init() gets called during
probe, this one second loop for each pcie interface instance ends up
extending the boot time.
Call trace when start_link() is not defined:
dw_pcie_wait_for_link << spins in a loop for 1 second
dw_pcie_host_init
Signed-off-by: Sajid Dalvi <sdalvi@google.com>
---
drivers/pci/controller/dwc/pcie-designware-host.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index 9952057c8819..9709f69f173e 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -489,10 +489,10 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)
ret = dw_pcie_start_link(pci);
if (ret)
goto err_remove_edma;
- }
- /* Ignore errors, the link may come up later */
- dw_pcie_wait_for_link(pci);
+ /* Ignore errors, the link may come up later */
+ dw_pcie_wait_for_link(pci);
+ }
bridge->sysdata = pp;
--
2.39.2.722.g9855ee24e9-goog
next reply other threads:[~2023-02-27 20:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 20:13 Sajid Dalvi [this message]
2023-02-28 22:04 ` [PATCH v2] PCI: dwc: Wait for link up only if link is started Han Jingoo
2023-03-01 4:36 ` Sajid Dalvi
2023-03-16 23:05 ` Sajid Dalvi
2023-04-05 13:24 ` Lorenzo Pieralisi
2023-04-05 18:27 ` Bjorn Helgaas
2023-04-05 18:58 ` William McVicker
2023-04-05 19:23 ` William McVicker
2023-04-06 3:50 ` Ajay Agarwal
2023-04-06 9:10 ` Ajay Agarwal
2023-04-07 17:40 ` William McVicker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227201340.2087605-1-sdalvi@google.com \
--to=sdalvi@google.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kernel-team@android.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox