Re: [PATCH v2 03/16] PCI: epf-test: Fix DMA transfer completion initialization

[Manivannan Sadhasivam <mani@kernel.org>]

On Wed, Mar 08, 2023 at 06:03:00PM +0900, Damien Le Moal wrote:
> Re-initialize the transfer_complete DMA transfer completion before
> calling tx_submit(), to avoid seeing the DMA transfer complete before
> the completion is initialized, thus potentially losing the completion
> notification.
> 
> Fixes: 8353813c88ef ("PCI: endpoint: Enable DMA tests for endpoints with DMA capabilities")

Please also CC stable list for backporting

> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

Thanks,
Mani

> ---
>  drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 0f9d2ec822ac..d65419735d2e 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -151,10 +151,10 @@ static int pci_epf_test_data_transfer(struct pci_epf_test *epf_test,
>  		return -EIO;
>  	}
>  
> +	reinit_completion(&epf_test->transfer_complete);
>  	tx->callback = pci_epf_test_dma_callback;
>  	tx->callback_param = epf_test;
>  	cookie = tx->tx_submit(tx);
> -	reinit_completion(&epf_test->transfer_complete);
>  
>  	ret = dma_submit_error(cookie);
>  	if (ret) {
> -- 
> 2.39.2
> 

-- 
மணிவண்ணன் சதாசிவம்