From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_krichai@quicinc.com, johan+linaro@kernel.org,
steev@kali.org, mka@chromium.org, Dhruva Gole <d-gole@ti.com>
Subject: Re: [PATCH v3 1/1] PCI: qcom: Add support for system suspend and resume
Date: Wed, 29 Mar 2023 22:07:31 +0530 [thread overview]
Message-ID: <20230329163731.GF5575@thinkpad> (raw)
In-Reply-To: <ZCROTyuxZ+dkrnx8@hovoldconsulting.com>
On Wed, Mar 29, 2023 at 04:42:23PM +0200, Johan Hovold wrote:
> On Wed, Mar 29, 2023 at 07:31:50PM +0530, Manivannan Sadhasivam wrote:
> > On Wed, Mar 29, 2023 at 03:19:51PM +0200, Johan Hovold wrote:
> > > On Wed, Mar 29, 2023 at 06:22:32PM +0530, Manivannan Sadhasivam wrote:
>
> > > Why would you need PCIe gen1 speed during suspend?
> >
> > That's what the suggestion I got from Qcom PCIe team. But I didn't compare the
> > value you added during icc support patch with downstream. More below...
> >
> > > These numbers are already somewhat random as, for example, the vendor
> > > driver is requesting 500 kBps (800 peak) during runtime, while we are
> > > now requesting five times that during suspend (the vendor driver gets a
> > > away with 0).
> >
> > Hmm, then I should've asked you this question when you added icc support.
> > I thought you inherited those values from downstream but apparently not.
> > Even in downstream they are using different bw votes for different platforms.
> > I will touch base with PCIe and ICC teams to find out the actual value that
> > needs to be used.
>
> We discussed things at length at the time, but perhaps it was before you
> joined to project.
Yeah, could be.
> As I alluded to above, we should not play the game of
> using arbitrary numbers but instead fix the interconnect driver so that
> it can map the interconnect values in kBps to something that makes sense
> for the Qualcomm hardware. Anything else is not acceptable for upstream.
>
Agree. I've started the discussion regarding this and will get back once I have
answers.
- Mani
> Johan
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-03-29 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 13:38 [PATCH v3 0/1] PCI: qcom: Add support for system suspend and resume Manivannan Sadhasivam
2023-03-27 13:38 ` [PATCH v3 1/1] " Manivannan Sadhasivam
2023-03-27 15:29 ` [EXT] " Frank Li
2023-03-29 13:02 ` Manivannan Sadhasivam
2023-03-29 13:04 ` Konrad Dybcio
2023-03-29 14:51 ` Frank Li
2023-03-29 9:56 ` Johan Hovold
2023-03-29 12:52 ` Manivannan Sadhasivam
2023-03-29 12:59 ` Konrad Dybcio
2023-03-29 13:19 ` Johan Hovold
2023-03-29 14:01 ` Manivannan Sadhasivam
2023-03-29 14:42 ` Johan Hovold
2023-03-29 16:37 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329163731.GF5575@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=d-gole@ti.com \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mka@chromium.org \
--cc=quic_krichai@quicinc.com \
--cc=robh@kernel.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).