From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7009C761AF for ; Wed, 29 Mar 2023 16:37:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230051AbjC2Qho (ORCPT ); Wed, 29 Mar 2023 12:37:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230038AbjC2Qhn (ORCPT ); Wed, 29 Mar 2023 12:37:43 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BB61448D for ; Wed, 29 Mar 2023 09:37:40 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id o6-20020a17090a9f8600b0023f32869993so19136801pjp.1 for ; Wed, 29 Mar 2023 09:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680107860; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=OoXdOK1goXOGy6MZ8rknbj6m2i3M9YHQmrM9+mBU2UY=; b=Dnlj0NaO3jozqwAh888qho/XSqr/vyYPK9vAM54KCcu3e3R/+b/dEK0Qlo8b+bwQX/ u7X5PKRrX+obOv0vY5JHQF/M3Kdthnk5pUvVYWNz3Qbcemvcx2Tunt+7/Xivla6yVv5L r9WE0wtG4leCyiolHaF3X3WpyrASgW/xfdlK5LB20hifgvDcIDWrQlTrSqLIkuDrN8Pz 8Ma2AEAqDME474EQ9knNF12Mv33uxmKnh7e0xtwfNdz/rPUBeJFUXYMt3EomEdY03Ffy Zt8duwuHkvpYGS+YtUh+f1csmn/hZ7AS8H8aq/caDBsX2kv0zkGCbj7hDD4V2ADqLMCB CCew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680107860; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OoXdOK1goXOGy6MZ8rknbj6m2i3M9YHQmrM9+mBU2UY=; b=f8i0yyySjiTJOlYcI5xw8zt1m88+i9IKQ4IFnpwE+TLzxf3my33lTrIIDwdXQX4R26 9x7sUw39LIpb6a7+AeBDm3Nz8QDgXDUEkTBMIW2+1KznibgXtRg5OyAzs4vGelChiwlN cXQ5LhhPJ7gPB4yECsYDOMdxPjrX+SizO67HkmraON5DJpqWeEimx/TdNNqBGCM9Xz4f ppni3CdkywZhAWhHjrmElyVV45S1B8VNM2QOgcDqjEGTz7ZOPEtREI5twa712MrIPuBu 30NCbDkeyzANI2rbZVoFGVlsDZ9Zlr0uBjd8CMd/uT6cD3DrOdOjk9/qQ6e7kxaLN30M pNRw== X-Gm-Message-State: AAQBX9eLEXbNWprzskd/PgudoeUtPvEM8J5THuySeXTbYyZVECaMNKA8 5lcyizNWOAiRdrjS4dy+D3sy X-Google-Smtp-Source: AKy350aCjpdIf4TPenzEjeGnTEkM9ymR9mj602qgyVc2HTWndzL4dALVGtahR9nVk0sOtZ/wl7qC9g== X-Received: by 2002:a17:903:210d:b0:1a0:53b3:ee87 with SMTP id o13-20020a170903210d00b001a053b3ee87mr15138590ple.62.1680107859849; Wed, 29 Mar 2023 09:37:39 -0700 (PDT) Received: from thinkpad ([117.216.120.213]) by smtp.gmail.com with ESMTPSA id g24-20020a170902869800b001a20b30e8b0sm11527315plo.243.2023.03.29.09.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 09:37:39 -0700 (PDT) Date: Wed, 29 Mar 2023 22:07:31 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_krichai@quicinc.com, johan+linaro@kernel.org, steev@kali.org, mka@chromium.org, Dhruva Gole Subject: Re: [PATCH v3 1/1] PCI: qcom: Add support for system suspend and resume Message-ID: <20230329163731.GF5575@thinkpad> References: <20230327133824.29136-1-manivannan.sadhasivam@linaro.org> <20230327133824.29136-2-manivannan.sadhasivam@linaro.org> <20230329125232.GB5575@thinkpad> <20230329140150.GE5575@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Mar 29, 2023 at 04:42:23PM +0200, Johan Hovold wrote: > On Wed, Mar 29, 2023 at 07:31:50PM +0530, Manivannan Sadhasivam wrote: > > On Wed, Mar 29, 2023 at 03:19:51PM +0200, Johan Hovold wrote: > > > On Wed, Mar 29, 2023 at 06:22:32PM +0530, Manivannan Sadhasivam wrote: > > > > Why would you need PCIe gen1 speed during suspend? > > > > That's what the suggestion I got from Qcom PCIe team. But I didn't compare the > > value you added during icc support patch with downstream. More below... > > > > > These numbers are already somewhat random as, for example, the vendor > > > driver is requesting 500 kBps (800 peak) during runtime, while we are > > > now requesting five times that during suspend (the vendor driver gets a > > > away with 0). > > > > Hmm, then I should've asked you this question when you added icc support. > > I thought you inherited those values from downstream but apparently not. > > Even in downstream they are using different bw votes for different platforms. > > I will touch base with PCIe and ICC teams to find out the actual value that > > needs to be used. > > We discussed things at length at the time, but perhaps it was before you > joined to project. Yeah, could be. > As I alluded to above, we should not play the game of > using arbitrary numbers but instead fix the interconnect driver so that > it can map the interconnect values in kBps to something that makes sense > for the Qualcomm hardware. Anything else is not acceptable for upstream. > Agree. I've started the discussion regarding this and will get back once I have answers. - Mani > Johan -- மணிவண்ணன் சதாசிவம்