From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B365C77B6C for ; Thu, 6 Apr 2023 18:35:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240217AbjDFSfM (ORCPT ); Thu, 6 Apr 2023 14:35:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240211AbjDFSfL (ORCPT ); Thu, 6 Apr 2023 14:35:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B11E859DA; Thu, 6 Apr 2023 11:35:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 483A662B54; Thu, 6 Apr 2023 18:35:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14497C433D2; Thu, 6 Apr 2023 18:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680806109; bh=IVpmg/9zjCkonOv9tBAoQgo1Lp6wBXA3GJcvRZ34LWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EpHrTPTEWANN+WTgkrZU/vS8IG9oFKJ/VaNRJC1jqFweHi5tY9N0r8+/FxxNuwvPg x/eDNMHq3jZEq/5WHV/Fwh5AXtGO7dI53Q5oMY3t98DRFehD1ssJsdSvjGBf7bvUJv RaF/jTEjYybYb2TpRLVMXNWQxTsbi6ph7ArSaeWphRJPLJlw/vbAQeiNNdBHTTgJOc joF+9MSK+6S0vVSfiFoOhM6ouqOv1+UktHwja2TLkfIEwxGqabDIKDdlC1fEMJNff1 IMBHbXa3ED/0khfcACoO5tXIu6NWO9KiZMkKuFBkPp1r1rIoMncz2QH5rNjIjeXZj7 paFbim0CZlyog== Date: Thu, 6 Apr 2023 19:35:03 +0100 From: Conor Dooley To: Krzysztof Kozlowski Cc: Minda Chen , Emil Renner Berthing , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-pci@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Philipp Zabel , Mason Huo , Leyfoon Tan , Kevin Xie Subject: Re: [PATCH v1 1/3] dt-binding: pci: add JH7110 PCIe dt-binding documents. Message-ID: <20230406-revisit-patchy-a0063d964070@spud> References: <20230406111142.74410-1-minda.chen@starfivetech.com> <20230406111142.74410-2-minda.chen@starfivetech.com> <38bc48bf-7d8c-8ddd-861f-3b7f3d2edce6@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8c3Cr3rYhW4crgm2" Content-Disposition: inline In-Reply-To: <38bc48bf-7d8c-8ddd-861f-3b7f3d2edce6@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org --8c3Cr3rYhW4crgm2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 06, 2023 at 08:24:55PM +0200, Krzysztof Kozlowski wrote: > On 06/04/2023 13:11, Minda Chen wrote: > > + > > + interrupt-controller: > > + type: object > > + properties: > > + '#address-cells': > > + const: 0 > > + > > + '#interrupt-cells': > > + const: 1 > > + > > + interrupt-controller: true > > + > > + required: > > + - '#address-cells' > > + - '#interrupt-cells' > > + - interrupt-controller > > + > > + additionalProperties: false > > + > > +required: > > + - reg > > + - reg-names > > + - "#interrupt-cells" >=20 > Keep consistent quotes - either ' or " >=20 > Are you sure this is correct? You have interrupt controller as child node. I know existing stuff in-tree is far from a guarantee that it'll be right, but this does at least follow what we've got for PolarFire SoC: Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml Both PLDA and both RISC-V w/ a PLIC as the interrupt controller, so in similar waters. This note existed in the original text form binding of the Microchip PCI controller: | +NOTE: | +The core provides a single interrupt for both INTx/MSI messages. So, | +create an interrupt controller node to support 'interrupt-map' DT | +functionality. The driver will create an IRQ domain for this map, decode | +the four INTx interrupts in ISR and route them to this domain. Given the similarities, I figure the same requirement applies here too. Minda? Cheers, Conor. --8c3Cr3rYhW4crgm2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZC8Q1wAKCRB4tDGHoIJi 0uVVAQDHgZupjjAEUR9lEnrmhcHf4bOLxjmLHOA7N0MNdc+M0gD+PTj3m9Z4X5bX gloCfnCtJczlVceBZUYlixYiqd/8pQA= =LjRe -----END PGP SIGNATURE----- --8c3Cr3rYhW4crgm2--