Re: [PATCH v3 6/6] PCI/AER: Unmask RCEC internal errors to enable RCH downstream port error handling

Bjorn Helgaas
2023-04-14T21:49:23Z

On Thu, Apr 13, 2023 at 03:38:07PM +0200, Robert Richter wrote:
> On 12.04.23 16:29:01, Bjorn Helgaas wrote:
> > On Tue, Apr 11, 2023 at 01:03:02PM -0500, Terry Bowman wrote:
> > > From: Robert Richter <rrichter@amd.com>
> > >
> > > RCEC AER corrected and uncorrectable internal errors (CIE/UIE) are
> > > disabled by default.

> > > +static void cxl_unmask_internal_errors(struct pci_dev *rcec)
>
> Also renaming this to cxl_enable_rcec() to more generalize the
> function.

I didn't follow this. "cxl_enable_rcec" doesn't say anything about
"unmasking" or "internal errors", which seems like the whole point.
And the function doesn't actually *enable* and RCEC.

> > > +{
> > > + if (!handles_cxl_errors(rcec))
> > > + return;
> > > +
> > > + if (__cxl_unmask_internal_errors(rcec))
> > > + dev_err(&rcec->dev, "cxl: Failed to unmask internal errors");
> > > + else
> > > + dev_dbg(&rcec->dev, "cxl: Internal errors unmasked");
>
> I am going to change this to a pci_info() for alignment with other
> messages around:
>
> [ 14.200265] pcieport 0000:40:00.3: PME: Signaling with IRQ 44
> [ 14.213925] pcieport 0000:40:00.3: AER: cxl: Internal errors unmasked
> [ 14.228413] pcieport 0000:40:00.3: AER: enabled with IRQ 44
>
> Plus, using pci_err() instead of dev_err().

Thanks for that!

Bjorn