Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
	oohall@gmail.com, Lukas Wunner <lukas@wunner.de>,
	Chris Chiu <chris.chiu@canonical.com>,
	Sathyanarayanan Kuppuswamy 
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Ashok Raj <ashok.raj@intel.com>,
	Sheng Bi <windy.bi.enflame@gmail.com>,
	Ravi Kishore Koppuravuri <ravi.kishore.koppuravuri@intel.com>,
	Stanislav Spassov <stanspas@amazon.de>,
	Yang Su <yang.su@linux.alibaba.com>,
	shuo.tan@linux.alibaba.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 0/2] PCI/PM: Resume/reset wait time change
Date: Tue, 11 Apr 2023 17:40:14 -0500	[thread overview]
Message-ID: <20230411224014.GA4185844@bhelgaas> (raw)
In-Reply-To: <20230404052714.51315-1-mika.westerberg@linux.intel.com>

On Tue, Apr 04, 2023 at 08:27:12AM +0300, Mika Westerberg wrote:
> Hi all,
> 
> This series first increases the time we wait on resume path to
> accommondate certain device, as reported in [1], and then "optimizes"
> the timeout for slow links to avoid too long waits if a device is
> disconnected during suspend.
> 
> Previous version can be found here:
> 
>   https://lore.kernel.org/linux-pci/20230321095031.65709-1-mika.westerberg@linux.intel.com/
> 
> Changes from the previous version:
> 
>   * Split the patch into two: one that increases the resume timeout (on
>     all links, I was not able to figure out a simple way to limit this
>     only for the fast links) and the one that decreases the timeout on
>     slow links.
> 
>   * Use dev->link_active_reporting instead of speed to figure out slow
>     vs. fast links.
> 
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=216728
> 
> Mika Westerberg (2):
>   PCI/PM: Increase wait time after resume

I applied the above to pci/reset for v6.4.

>   PCI/PM: Decrease wait time for devices behind slow links

Part of this patch is removing the pci_bridge_wait_for_secondary_bus()
timeout parameter, since all callers now supply the same value
(PCIE_RESET_READY_POLL_MS).  I extracted that part out and applied it
as well.

I'm hoping we can restructure the rest of this as mentioned in the
thread.  If that's not possible, can you rebase what's left on top of
this?

  https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=reset

>  drivers/pci/pci-driver.c |  2 +-
>  drivers/pci/pci.c        | 42 ++++++++++++++++++++++++++--------------
>  drivers/pci/pci.h        | 16 +--------------
>  drivers/pci/pcie/dpc.c   |  3 +--
>  4 files changed, 30 insertions(+), 33 deletions(-)
> 
> -- 
> 2.39.2
> 

  parent reply	other threads:[~2023-04-11 22:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04  5:27 [PATCH v2 0/2] PCI/PM: Resume/reset wait time change Mika Westerberg
2023-04-04  5:27 ` [PATCH v2 1/2] PCI/PM: Increase wait time after resume Mika Westerberg
2023-04-04  5:27 ` [PATCH v2 2/2] PCI/PM: Decrease wait time for devices behind slow links Mika Westerberg
2023-04-04 21:36   ` Bjorn Helgaas
2023-04-05  9:39     ` Mika Westerberg
2023-04-06 17:55       ` Bjorn Helgaas
2023-04-11 22:40 ` Bjorn Helgaas [this message]
2023-04-12  8:00   ` [PATCH v2 0/2] PCI/PM: Resume/reset wait time change Mika Westerberg
2023-04-12 19:25     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230411224014.GA4185844@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=ashok.raj@intel.com \
    --cc=bhelgaas@google.com \
    --cc=chris.chiu@canonical.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mahesh@linux.ibm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=oohall@gmail.com \
    --cc=ravi.kishore.koppuravuri@intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=shuo.tan@linux.alibaba.com \
    --cc=stanspas@amazon.de \
    --cc=windy.bi.enflame@gmail.com \
    --cc=yang.su@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox