linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-renesas-soc@vger.kernel.org
Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	"Marek Vasut" <marek.vasut+renesas@gmail.com>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 2/3] PCI: rcar-host: add support for optional regulators
Date: Mon,  8 May 2023 12:45:56 +0200	[thread overview]
Message-ID: <20230508104557.47889-3-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20230508104557.47889-1-wsa+renesas@sang-engineering.com>

The KingFisher board has regulators. They just need to be en-/disabled,
so we can leave the handling to devm.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/pci/controller/pcie-rcar-host.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c
index e80e56b2a842..b0e4834176d2 100644
--- a/drivers/pci/controller/pcie-rcar-host.c
+++ b/drivers/pci/controller/pcie-rcar-host.c
@@ -29,6 +29,7 @@
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
+#include <linux/regulator/consumer.h>
 
 #include "pcie-rcar.h"
 
@@ -992,6 +993,14 @@ static int rcar_pcie_probe(struct platform_device *pdev)
 	pcie->dev = dev;
 	platform_set_drvdata(pdev, host);
 
+	err = devm_regulator_get_enable_optional(dev, "vpcie3v3");
+	if (err < 0 && err != -ENODEV)
+		dev_err_probe(dev, err, "error enabling 3.3V regulator");
+
+	err = devm_regulator_get_enable_optional(dev, "vpcie1v5");
+	if (err < 0 && err != -ENODEV)
+		dev_err_probe(dev, err, "error enabling 1.5V regulator");
+
 	pm_runtime_enable(pcie->dev);
 	err = pm_runtime_get_sync(pcie->dev);
 	if (err < 0) {
-- 
2.30.2


  parent reply	other threads:[~2023-05-08 10:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08 10:45 [RFC PATCH 0/3] KingFisher: support regulators for PCIe Wolfram Sang
2023-05-08 10:45 ` [RFC PATCH 1/3] dt-bindings: PCI: rcar-pci-host: add optional regulators Wolfram Sang
2023-05-08 11:27   ` Rob Herring
2023-05-08 13:40   ` Geert Uytterhoeven
2023-05-08 18:48     ` Wolfram Sang
2023-05-09 10:35       ` Geert Uytterhoeven
2023-05-09 12:30         ` Wolfram Sang
2023-05-08 10:45 ` Wolfram Sang [this message]
2023-05-08 13:45   ` [RFC PATCH 2/3] PCI: rcar-host: add support for " Geert Uytterhoeven
2023-05-09 10:20     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230508104557.47889-3-wsa+renesas@sang-engineering.com \
    --to=wsa+renesas@sang-engineering.com \
    --cc=bhelgaas@google.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=robh@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).