From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95340C77B75 for ; Mon, 8 May 2023 21:31:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232643AbjEHVbO (ORCPT ); Mon, 8 May 2023 17:31:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjEHVbL (ORCPT ); Mon, 8 May 2023 17:31:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CF4A10EC; Mon, 8 May 2023 14:31:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 03559642AC; Mon, 8 May 2023 21:31:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31388C433EF; Mon, 8 May 2023 21:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683581468; bh=T0A52YhbVC0xShcDektXWFKw+mqnN3k3AY2OPTdnEjg=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=SOAlUBWI1RiZWt4v/no1jMnVz5vsHRWC2dBBSgu+0aa6liSOZwgEjQbPrfmfwkHHd ILaGwcnaIIg7BHxDSihUs3mN3XnskViXm/8m651NE0q+h5VHuJzKgHP4u/+gNjTRjB 8+ko+NbXdY43bHh3j6RNCenshzNAOK2waDgHlP4c92mJ/DJb6y1CK4NNgSWpdhtEgc ysOmHf1sL7Vio+P+ydRnTNaP2wOCN+2a5C2gVVI8JLWQX10LIiffiHx40GFLUcMUSs aUsd3zbTFdYjBRhT4u/2xvwZ1jpzG9pzddicUmBXu8z+kTVhbLQnwU9At99GnQoFgx QdT91TV03NtRQ== Date: Mon, 8 May 2023 16:31:06 -0500 From: Bjorn Helgaas To: Frank Li Cc: Manivannan Sadhasivam , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "imx@lists.linux.dev" , Rob Herring , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Lorenzo Pieralisi , open list , "M.H. Lian" , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Roy Zang , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Mingkai Hu Subject: Re: [EXT] Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint linkup notifier support Message-ID: <20230508213106.GA1192065@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, May 08, 2023 at 01:31:26PM +0000, Frank Li wrote: > > -----Original Message----- > > From: Manivannan Sadhasivam > > Sent: Saturday, May 6, 2023 2:59 AM > > To: Frank Li > > Cc: M.H. Lian ; Mingkai Hu > > ; Roy Zang ; Lorenzo Pieralisi > > ; Rob Herring ; Krzysztof > > Wilczyński ; Bjorn Helgaas ; open > > list:PCI DRIVER FOR FREESCALE LAYERSCAPE ; > > open list:PCI DRIVER FOR FREESCALE LAYERSCAPE > pci@vger.kernel.org>; moderated list:PCI DRIVER FOR FREESCALE > > LAYERSCAPE ; open list > kernel@vger.kernel.org>; imx@lists.linux.dev > > Subject: [EXT] Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint linkup > > notifier support All these quoted headers are redundant clutter since we've already seen them when Manivannan sent his comments. It would be nice if your mailer could be configured to omit them. > > > +static int ls_pcie_ep_interrupt_init(struct ls_pcie_ep *pcie, > > > + struct platform_device *pdev) > > > +{ > > > + u32 val; > > > + int ret; > > > + > > > + pcie->irq = platform_get_irq_byname(pdev, "pme"); > > > + if (pcie->irq < 0) { > > > + dev_err(&pdev->dev, "Can't get 'pme' IRQ\n"); > > > > PME > > Here should be dts property `pme`, suppose should match > platform_get_irq_byname(pdev, "pme"); You can also edit out all the other context and questions if you're not responding to them. There were a lot of other comments that were useful but are not relevant to this reply. Bjorn