From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A3C3C7EE26 for ; Tue, 16 May 2023 11:46:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232223AbjEPLq2 (ORCPT ); Tue, 16 May 2023 07:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232428AbjEPLqV (ORCPT ); Tue, 16 May 2023 07:46:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B9305596; Tue, 16 May 2023 04:46:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8D0F2638C0; Tue, 16 May 2023 11:46:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 711C6C4339B; Tue, 16 May 2023 11:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684237580; bh=/6URK8ebxKRAr1E5o6SIqB7r+nUmDZOUBzaa5dq3/fw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iGdJ2rYsmqR8oVsZahQCffWW98XsY3ZQUeXnWDOdK/AEAQZPWGakOfz+Feazfr/vl zwZZikKODPH3BvcBxPlO97qsEGQqvFknbw/tEto+OjmYA+dy8uQzKCCOKDXOXurVb1 Cn+gG0WOxgz6wHXyTwJKTcrMiK15YYAZk/wJYeq4= Date: Tue, 16 May 2023 13:46:17 +0200 From: Greg Kroah-Hartman To: Niklas Schnelle Cc: Arnd Bergmann , Corey Minyard , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Bjorn Helgaas , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , Corey Minyard , openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org Subject: Re: [PATCH v4 03/41] char: impi, tpm: depend on HAS_IOPORT Message-ID: <2023051656-mammary-cobweb-7265@gregkh> References: <20230516110038.2413224-1-schnelle@linux.ibm.com> <20230516110038.2413224-4-schnelle@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230516110038.2413224-4-schnelle@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, May 16, 2023 at 12:59:59PM +0200, Niklas Schnelle wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add this dependency and ifdef > sections of code using inb()/outb() as alternative access methods. > > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Acked-by: Corey Minyard # IPMI > Reviewed-by: Jarkko Sakkinen > Signed-off-by: Niklas Schnelle > --- > Note: The HAS_IOPORT Kconfig option was added in v6.4-rc1 so > per-subsystem patches may be applied independently > > drivers/char/Kconfig | 3 ++- > drivers/char/ipmi/Makefile | 11 ++++------- > drivers/char/ipmi/ipmi_si_intf.c | 3 ++- > drivers/char/ipmi/ipmi_si_pci.c | 3 +++ > drivers/char/tpm/Kconfig | 1 + > drivers/char/tpm/tpm_infineon.c | 16 ++++++++++++---- > drivers/char/tpm/tpm_tis_core.c | 19 ++++++++----------- > 7 files changed, 32 insertions(+), 24 deletions(-) TPM and IPMI patches go through different git trees, so odds are you are going to have to split this patch in 2. thanks, greg k-h