From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA9C6C7EE23 for ; Wed, 7 Jun 2023 20:23:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233209AbjFGUXV (ORCPT ); Wed, 7 Jun 2023 16:23:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233090AbjFGUXH (ORCPT ); Wed, 7 Jun 2023 16:23:07 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6257270A; Wed, 7 Jun 2023 13:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686169364; x=1717705364; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ptcJdaHahJRD2fNGZZ0WMUGd3tX28UXr2OYz7pD6acg=; b=lSD/SAdjjJOE5Zmq9fy1SBGhvrcmcQsTjP3huXF1mcXJsx9g2cH9+NIA 5YJx+BB1gqxUgjln/LJ1i2Um6du3Z3B5eD1aHvFQoMxg+S3KPjUaTtqfh igtAPcFgIOKZBqMTmTSVXGCZev93CE/yaCQk5RB9H1I4+G4ytVYvVScq3 bBBZMJd4hlomIDJOH8abAK2frwuq2jZrHQx9TT09yBilxMDG1G+yNYkcW XUE2lerTZnATw9emVao7wrOZAY1ps/TIzBC9Ei9AmjTKLYPx8dMN/ojBa N0St160DQZ4Sby3WP+g74AL8lyfoI+DJWx/1CiVoeAy3HNDsZlfIw8L1A w==; X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="357109028" X-IronPort-AV: E=Sophos;i="6.00,225,1681196400"; d="scan'208";a="357109028" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 13:20:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="739418877" X-IronPort-AV: E=Sophos;i="6.00,225,1681196400"; d="scan'208";a="739418877" Received: from lkp-server01.sh.intel.com (HELO 15ab08e44a81) ([10.239.97.150]) by orsmga008.jf.intel.com with ESMTP; 07 Jun 2023 13:20:40 -0700 Received: from kbuild by 15ab08e44a81 with local (Exim 4.96) (envelope-from ) id 1q6ze4-0006tD-2X; Wed, 07 Jun 2023 20:20:40 +0000 Date: Thu, 8 Jun 2023 04:19:52 +0800 From: kernel test robot To: Yang Li , mani@kernel.org Cc: oe-kbuild-all@lists.linux.dev, lpieralisi@kernel.org, kw@linux.com, kishon@kernel.org, bhelgaas@google.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: Re: [PATCH -next] PCI: endpoint: Remove redundant dev_err(). Message-ID: <202306080418.i64hTj5T-lkp@intel.com> References: <20230607093514.104012-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230607093514.104012-1-yang.lee@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Yang, kernel test robot noticed the following build warnings: [auto build test WARNING on next-20230607] url: https://github.com/intel-lab-lkp/linux/commits/Yang-Li/PCI-endpoint-Remove-redundant-dev_err/20230607-173708 base: next-20230607 patch link: https://lore.kernel.org/r/20230607093514.104012-1-yang.lee%40linux.alibaba.com patch subject: [PATCH -next] PCI: endpoint: Remove redundant dev_err(). config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230608/202306080418.i64hTj5T-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): git checkout next-20230607 b4 shazam https://lore.kernel.org/r/20230607093514.104012-1-yang.lee@linux.alibaba.com # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/pci/endpoint/functions/ If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306080418.i64hTj5T-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/pci/endpoint/functions/pci-epf-mhi.c: In function 'pci_epf_mhi_bind': >> drivers/pci/endpoint/functions/pci-epf-mhi.c:347:24: warning: unused variable 'dev' [-Wunused-variable] 347 | struct device *dev = &epf->dev; | ^~~ vim +/dev +347 drivers/pci/endpoint/functions/pci-epf-mhi.c 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 341 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 342 static int pci_epf_mhi_bind(struct pci_epf *epf) 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 343 { 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 344 struct pci_epf_mhi *epf_mhi = epf_get_drvdata(epf); 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 345 struct pci_epc *epc = epf->epc; 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 346 struct platform_device *pdev = to_platform_device(epc->dev.parent); 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 @347 struct device *dev = &epf->dev; 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 348 struct resource *res; 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 349 int ret; 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 350 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 351 /* Get MMIO base address from Endpoint controller */ 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 352 res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mmio"); 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 353 epf_mhi->mmio_phys = res->start; 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 354 epf_mhi->mmio_size = resource_size(res); 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 355 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 356 epf_mhi->mmio = ioremap(epf_mhi->mmio_phys, epf_mhi->mmio_size); 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 357 if (IS_ERR(epf_mhi->mmio)) 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 358 return PTR_ERR(epf_mhi->mmio); 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 359 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 360 ret = platform_get_irq_byname(pdev, "doorbell"); 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 361 if (ret < 0) { 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 362 iounmap(epf_mhi->mmio); 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 363 return ret; 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 364 } 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 365 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 366 epf_mhi->irq = ret; 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 367 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 368 return 0; 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 369 } 7db424a84d96b0 Manivannan Sadhasivam 2023-06-02 370 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki