From: korantwork@gmail.com
To: kw@linux.com, nirmal.patel@linux.intel.com
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
linux-pci@vger.kernel.org, Xinghui Li <korantli@tencent.com>,
Dan Carpenter <error27@gmail.com>
Subject: [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch
Date: Tue, 27 Jun 2023 19:38:08 +0800 [thread overview]
Message-ID: <20230627113808.269716-1-korantwork@gmail.com> (raw)
From: Xinghui Li <korantli@tencent.com>
There is one inconsistent indenting warning:
"drivers/pci/controller/vmd.c:1058 vmd_resume()
warn: inconsistent indenting"
Fix it and remove the unnecessary if.
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Xinghui Li <korantli@tencent.com>
---
drivers/pci/controller/vmd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 990630ec57c6..356bbeb548fe 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -1055,10 +1055,7 @@ static int vmd_resume(struct device *dev)
struct vmd_dev *vmd = pci_get_drvdata(pdev);
int err, i;
- if (vmd->irq_domain)
- vmd_set_msi_remapping(vmd, true);
- else
- vmd_set_msi_remapping(vmd, false);
+ vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
for (i = 0; i < vmd->msix_count; i++) {
err = devm_request_irq(dev, vmd->irqs[i].virq,
--
2.39.3
next reply other threads:[~2023-06-27 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 11:38 korantwork [this message]
2023-08-30 8:38 ` [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627113808.269716-1-korantwork@gmail.com \
--to=korantwork@gmail.com \
--cc=error27@gmail.com \
--cc=hch@infradead.org \
--cc=korantli@tencent.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nirmal.patel@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).