From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D9DEB64DC for ; Tue, 18 Jul 2023 19:03:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230324AbjGRTDB (ORCPT ); Tue, 18 Jul 2023 15:03:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbjGRTDB (ORCPT ); Tue, 18 Jul 2023 15:03:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DA84F0 for ; Tue, 18 Jul 2023 12:03:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C74A061523 for ; Tue, 18 Jul 2023 19:02:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA86EC433C7; Tue, 18 Jul 2023 19:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689706979; bh=9vPUgFai6+PiBGKsqSUVDRXMxlEQdzKUq4l/05ZAfyg=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=McTGQ6o2Tmgk+7P1nQTm/KwOEjwMuM4MRmjIIo3r+7kIIcLO4LON/riJ9jYbRcTpg UlqhV9khAdLQUrtR36N4x/pB8GP6/LhGC5cCT69Cayc0r+lzDviSWnValJDqrLTAmh fQ8IHSXfU0WXlIIV544bf0niv7qrlO22B8HamIjmk8yM67OuEtuHkV1MBYwywBa3zy vj5/i4DW5bSfygO1Mj+mEk4rNiPJGzzH6rj1C/EMs0ZB710vw+326ijblppGHbuC6z FWZ+pUPUnRqDeDLi+121I+r2uji4O9KABXtIRgfzM3exspoaofFzekSc4ojTjDNxeL 5RCVZP0J1FAtA== Date: Tue, 18 Jul 2023 14:02:52 -0500 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Krzysztof Wilczynski , Lorenzo Pieralisi , linux-pci@vger.kernel.org, Radu Rendec Subject: Re: Future of pci-mvebu Message-ID: <20230718190252.GA489311@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230718165703.adgkqb4jadmnx73c@pali> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Jul 18, 2023 at 06:57:03PM +0200, Pali Rohár wrote: > On Tuesday 18 July 2023 06:19:52 Bjorn Helgaas wrote: > > On Tue, Jul 18, 2023 at 12:03:17AM +0200, Pali Rohár wrote: > > > Hello, I have just one question. What do you want to do with pci-mvebu > > > driver? It is already marked as broken for 3 kernel releases and I do > > > not see any progress from anybody (and you rejected my fixes). How long > > > do you want it to have marked as broken? > > > > I don't think "depends on BROKEN" necessarily means that we plan to > > remove the driver. I think it just means that it's currently broken, > > but we hope to fix it eventually. > > > > I think the problem here is the regular vs chained interrupt handlers, > > right? Radu has been looking at that recently, too, so maybe we can > > have another go at it. > > I guess that this is the main issue as all other fixes and improvements > are stalled. If these other things don't depend on this IRQ issue, maybe we could still make progress on them? Maybe post them again (rebasing to v6.5-rc1 if necessary)? Often I forget or miss things, so it doesn't hurt to try again if you don't hear anything. > Just to remind that we have there shared interrupt source > (which can be requested by more HW drivers) and consumer is PCIe INTX > which is de-facto chained handler. And I have not seen anything for > shared interrupt source except request_irq(IRQF_SHARED) which you do not > want to use for shared interrupts anymore. Also setting of PCIe INTX > affinity is broken which worked fine with the previous kernel versions. > And you also rejected fixes for this regression. This sounds like the issue where we haven't figured out how to make both Marc and Thomas happy at the same time. I don't know much about IRQs, but I'm still optimistic that it may be possible because I don't think there's anything really unique about mvebu here. Bjorn