linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Krzysztof Wilczynski <kw@linux.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	linux-pci@vger.kernel.org, Radu Rendec <rrendec@redhat.com>
Subject: Re: Future of pci-mvebu
Date: Tue, 18 Jul 2023 21:21:52 +0200	[thread overview]
Message-ID: <20230718192152.b4ic3nptfpsrrtui@pali> (raw)
In-Reply-To: <20230718190252.GA489311@bhelgaas>

On Tuesday 18 July 2023 14:02:52 Bjorn Helgaas wrote:
> On Tue, Jul 18, 2023 at 06:57:03PM +0200, Pali Rohár wrote:
> > On Tuesday 18 July 2023 06:19:52 Bjorn Helgaas wrote:
> > > On Tue, Jul 18, 2023 at 12:03:17AM +0200, Pali Rohár wrote:
> > > > Hello, I have just one question. What do you want to do with pci-mvebu
> > > > driver? It is already marked as broken for 3 kernel releases and I do
> > > > not see any progress from anybody (and you rejected my fixes). How long
> > > > do you want it to have marked as broken?
> > > 
> > > I don't think "depends on BROKEN" necessarily means that we plan to
> > > remove the driver.  I think it just means that it's currently broken,
> > > but we hope to fix it eventually.
> > > 
> > > I think the problem here is the regular vs chained interrupt handlers,
> > > right?  Radu has been looking at that recently, too, so maybe we can
> > > have another go at it.
> > 
> > I guess that this is the main issue as all other fixes and improvements
> > are stalled. 
> 
> If these other things don't depend on this IRQ issue, maybe we could
> still make progress on them?  Maybe post them again (rebasing to
> v6.5-rc1 if necessary)?  Often I forget or miss things, so it doesn't
> hurt to try again if you don't hear anything.

In past I (re)sent changes at least 3 times. And would not do it again.

> > Just to remind that we have there shared interrupt source
> > (which can be requested by more HW drivers) and consumer is PCIe INTX
> > which is de-facto chained handler. And I have not seen anything for
> > shared interrupt source except request_irq(IRQF_SHARED) which you do not
> > want to use for shared interrupts anymore. Also setting of PCIe INTX
> > affinity is broken which worked fine with the previous kernel versions.
> > And you also rejected fixes for this regression.
> 
> This sounds like the issue where we haven't figured out how to make
> both Marc and Thomas happy at the same time.  I don't know much about
> IRQs, but I'm still optimistic that it may be possible because I don't
> think there's anything really unique about mvebu here.
> 
> Bjorn

At I pointed out, nothing happened for 3 kernel releases and also
nothing happened since my last attempt there. I'm not going to waste
more time on it as I already saw results and I'm not going to repeat
them. Look at the current result - it does not work.

  reply	other threads:[~2023-07-18 19:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 22:03 Future of pci-mvebu Pali Rohár
2023-07-18  9:16 ` Serge Semin
2023-07-18 11:19 ` Bjorn Helgaas
2023-07-18 11:50   ` Manivannan Sadhasivam
2023-07-18 11:54     ` Manivannan Sadhasivam
2023-07-18 16:57   ` Pali Rohár
2023-07-18 19:02     ` Bjorn Helgaas
2023-07-18 19:21       ` Pali Rohár [this message]
2023-07-18 19:28         ` Bjorn Helgaas
2023-07-18 19:40           ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230718192152.b4ic3nptfpsrrtui@pali \
    --to=pali@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=rrendec@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).