From: Bjorn Helgaas <helgaas@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] PCI: ibmphp: make read-only arrays static
Date: Tue, 18 Jul 2023 16:53:30 -0500 [thread overview]
Message-ID: <20230718215330.GA496036@bhelgaas> (raw)
In-Reply-To: <20230627125612.724764-1-colin.i.king@gmail.com>
On Tue, Jun 27, 2023 at 01:56:12PM +0100, Colin Ian King wrote:
> Don't populate the arrays on the stack, instead make them static const.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Applied to pci/hotplug for v6.6, thanks!
> ---
> drivers/pci/hotplug/ibmphp_pci.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/hotplug/ibmphp_pci.c b/drivers/pci/hotplug/ibmphp_pci.c
> index 754c3f23282e..50038e5f9ca4 100644
> --- a/drivers/pci/hotplug/ibmphp_pci.c
> +++ b/drivers/pci/hotplug/ibmphp_pci.c
> @@ -329,7 +329,7 @@ int ibmphp_configure_card(struct pci_func *func, u8 slotno)
> static int configure_device(struct pci_func *func)
> {
> u32 bar[6];
> - u32 address[] = {
> + static const u32 address[] = {
> PCI_BASE_ADDRESS_0,
> PCI_BASE_ADDRESS_1,
> PCI_BASE_ADDRESS_2,
> @@ -564,7 +564,7 @@ static int configure_bridge(struct pci_func **func_passed, u8 slotno)
> struct resource_node *pfmem = NULL;
> struct resource_node *bus_pfmem[2] = {NULL, NULL};
> struct bus_node *bus;
> - u32 address[] = {
> + static const u32 address[] = {
> PCI_BASE_ADDRESS_0,
> PCI_BASE_ADDRESS_1,
> 0
> @@ -1053,7 +1053,7 @@ static struct res_needed *scan_behind_bridge(struct pci_func *func, u8 busno)
> int howmany = 0; /*this is to see if there are any devices behind the bridge */
>
> u32 bar[6], class;
> - u32 address[] = {
> + static const u32 address[] = {
> PCI_BASE_ADDRESS_0,
> PCI_BASE_ADDRESS_1,
> PCI_BASE_ADDRESS_2,
> @@ -1182,7 +1182,7 @@ static struct res_needed *scan_behind_bridge(struct pci_func *func, u8 busno)
> static int unconfigure_boot_device(u8 busno, u8 device, u8 function)
> {
> u32 start_address;
> - u32 address[] = {
> + static const u32 address[] = {
> PCI_BASE_ADDRESS_0,
> PCI_BASE_ADDRESS_1,
> PCI_BASE_ADDRESS_2,
> @@ -1310,7 +1310,7 @@ static int unconfigure_boot_bridge(u8 busno, u8 device, u8 function)
> struct resource_node *mem = NULL;
> struct resource_node *pfmem = NULL;
> struct bus_node *bus;
> - u32 address[] = {
> + static const u32 address[] = {
> PCI_BASE_ADDRESS_0,
> PCI_BASE_ADDRESS_1,
> 0
> --
> 2.39.2
>
prev parent reply other threads:[~2023-07-18 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 12:56 [PATCH][next] PCI: ibmphp: make read-only arrays static Colin Ian King
2023-07-18 21:53 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718215330.GA496036@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).