Re: [PATCH 2/5] PCI: endpoint: pci-epf-mhi: Constify pci_epf_ops and pci_epf_event_ops

[Manivannan Sadhasivam <mani@kernel.org>]

On Sat, Jul 22, 2023 at 04:08:45PM -0700, Lars-Peter Clausen wrote:
> Both the pci_epf_ops and pci_epf_evnt_ops structs for the PCI endpoint mhi
> driver are never modified. Mark them as const so they can be placed in the
> read-only section.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

> ---
>  drivers/pci/endpoint/functions/pci-epf-mhi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c
> index 9c1f5a154fbd..bb1c8e502a09 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-mhi.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c
> @@ -389,7 +389,7 @@ static void pci_epf_mhi_unbind(struct pci_epf *epf)
>  	pci_epc_clear_bar(epc, epf->func_no, epf->vfunc_no, epf_bar);
>  }
>  
> -static struct pci_epc_event_ops pci_epf_mhi_event_ops = {
> +static const struct pci_epc_event_ops pci_epf_mhi_event_ops = {
>  	.core_init = pci_epf_mhi_core_init,
>  	.link_up = pci_epf_mhi_link_up,
>  	.link_down = pci_epf_mhi_link_down,
> @@ -428,7 +428,7 @@ static const struct pci_epf_device_id pci_epf_mhi_ids[] = {
>  	{},
>  };
>  
> -static struct pci_epf_ops pci_epf_mhi_ops = {
> +static const struct pci_epf_ops pci_epf_mhi_ops = {
>  	.unbind	= pci_epf_mhi_unbind,
>  	.bind	= pci_epf_mhi_bind,
>  };
> -- 
> 2.39.2
> 

-- 
மணிவண்ணன் சதாசிவம்