From: Manivannan Sadhasivam <mani@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jon Mason" <jdmason@kudzu.us>,
"Dave Jiang" <dave.jiang@intel.com>,
"Allen Hubbe" <allenbh@gmail.com>,
linux-pci@vger.kernel.org, mhi@lists.linux.dev,
ntb@lists.linux.dev
Subject: Re: [PATCH 5/5] PCI: endpoint: pci-epf-test: Constify pci_epf_ops
Date: Mon, 24 Jul 2023 11:33:15 +0530 [thread overview]
Message-ID: <20230724060315.GG2370@thinkpad> (raw)
In-Reply-To: <20230722230848.589428-5-lars@metafoo.de>
On Sat, Jul 22, 2023 at 04:08:48PM -0700, Lars-Peter Clausen wrote:
> The pci_epf_ops struct for the PCI endpoint test driver is never modified.
> Mark it as const so it can be placed in the read-only section.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
- Mani
> ---
> drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 1f0d2b84296a..7cc1c5c70afc 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -973,7 +973,7 @@ static int pci_epf_test_probe(struct pci_epf *epf,
> return 0;
> }
>
> -static struct pci_epf_ops ops = {
> +static const struct pci_epf_ops ops = {
> .unbind = pci_epf_test_unbind,
> .bind = pci_epf_test_bind,
> };
> --
> 2.39.2
>
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-07-24 6:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 23:08 [PATCH 1/5] PCI: endpoint: Make pci_epf_ops in pci_epf_driver const Lars-Peter Clausen
2023-07-22 23:08 ` [PATCH 2/5] PCI: endpoint: pci-epf-mhi: Constify pci_epf_ops and pci_epf_event_ops Lars-Peter Clausen
2023-07-24 6:01 ` Manivannan Sadhasivam
2023-07-22 23:08 ` [PATCH 3/5] PCI: endpoint: pci-epf-ntb: Constify pci_epf_ops Lars-Peter Clausen
2023-07-24 6:02 ` Manivannan Sadhasivam
2023-07-22 23:08 ` [PATCH 4/5] PCI: endpoint: pci-epf-vntb: " Lars-Peter Clausen
2023-07-24 6:02 ` Manivannan Sadhasivam
2023-07-22 23:08 ` [PATCH 5/5] PCI: endpoint: pci-epf-test: " Lars-Peter Clausen
2023-07-24 6:03 ` Manivannan Sadhasivam [this message]
2023-07-24 6:00 ` [PATCH 1/5] PCI: endpoint: Make pci_epf_ops in pci_epf_driver const Manivannan Sadhasivam
2023-12-18 22:43 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724060315.GG2370@thinkpad \
--to=mani@kernel.org \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=lars@metafoo.de \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).