From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56281EB64DD for ; Mon, 24 Jul 2023 06:04:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbjGXGD7 (ORCPT ); Mon, 24 Jul 2023 02:03:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbjGXGD6 (ORCPT ); Mon, 24 Jul 2023 02:03:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193561B2 for ; Sun, 23 Jul 2023 23:03:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A288460F31 for ; Mon, 24 Jul 2023 06:03:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F2E0C433C7; Mon, 24 Jul 2023 06:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690178610; bh=9wos/qYbisNIf8X7qlZuN3x+iNys+HSTfdq4nyJw1+Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UXrzuiQti9wk8XGirwx45RKsVK7bvs2kfiP3agqSt3MtHtCSWDCEhAGzC0Jk5fPGV cB2aebtAeFiNuGzsbJQx8HKnkm3oYpQ61+vbDjBED7Ez8/67fmHfn1cplKLYJ6JGsP WLSGwpYGJGtAXZd75PBYHVNKvQ43RHp+BqJaeKRj59JjOQTitJZmKSwyFdCtpJz6Yz 2lpihiORU6kZPBGEzYy+e4fcFsrbsL6veSPutaVQy1nAKBOtNyloQ73bDznIqx4OpR 1XnVMmG38CMx2hZhl18+1tGTgRWd/vAakkhl8KgfWshvLeyaa2cONMUoa5UkQDEzUJ 7adFLew2SkYOg== Date: Mon, 24 Jul 2023 11:33:15 +0530 From: Manivannan Sadhasivam To: Lars-Peter Clausen Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Jon Mason , Dave Jiang , Allen Hubbe , linux-pci@vger.kernel.org, mhi@lists.linux.dev, ntb@lists.linux.dev Subject: Re: [PATCH 5/5] PCI: endpoint: pci-epf-test: Constify pci_epf_ops Message-ID: <20230724060315.GG2370@thinkpad> References: <20230722230848.589428-1-lars@metafoo.de> <20230722230848.589428-5-lars@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230722230848.589428-5-lars@metafoo.de> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sat, Jul 22, 2023 at 04:08:48PM -0700, Lars-Peter Clausen wrote: > The pci_epf_ops struct for the PCI endpoint test driver is never modified. > Mark it as const so it can be placed in the read-only section. > > Signed-off-by: Lars-Peter Clausen Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/endpoint/functions/pci-epf-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 1f0d2b84296a..7cc1c5c70afc 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -973,7 +973,7 @@ static int pci_epf_test_probe(struct pci_epf *epf, > return 0; > } > > -static struct pci_epf_ops ops = { > +static const struct pci_epf_ops ops = { > .unbind = pci_epf_test_unbind, > .bind = pci_epf_test_bind, > }; > -- > 2.39.2 > -- மணிவண்ணன் சதாசிவம்